Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use TestWatchdog from hedgehog-extras. #5857

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

carbolymer
Copy link
Contributor

@carbolymer carbolymer commented May 27, 2024

Description

Use TestWatchdog from hedgehog-extras. Includes #5856

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@carbolymer carbolymer changed the title Use `Test Use TestWatchdog from hedgehog-extras. May 27, 2024
@carbolymer carbolymer force-pushed the mgalazyn/test/use-hedgehog-test-watchdog branch 7 times, most recently from be42a99 to 43c0671 Compare May 28, 2024 11:50
@carbolymer carbolymer marked this pull request as ready for review May 28, 2024 11:53
@carbolymer carbolymer requested review from a team as code owners May 28, 2024 11:53
@carbolymer carbolymer force-pushed the mgalazyn/test/use-hedgehog-test-watchdog branch from 43c0671 to fb20fd3 Compare May 28, 2024 12:54
cabal.project Outdated
@@ -54,6 +54,10 @@ package bitvec
package plutus-scripts-bench
haddock-options: "--optghc=-fplugin-opt PlutusTx.Plugin:defer-errors"

constraints:
io-classes-mtl < 0.1.2.0,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the status on io-classes-mtl?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smelc smelc force-pushed the mgalazyn/test/use-hedgehog-test-watchdog branch from fb20fd3 to 8a3fbe3 Compare May 31, 2024 08:33
@smelc smelc force-pushed the mgalazyn/test/use-hedgehog-test-watchdog branch from 8a3fbe3 to e0df963 Compare June 3, 2024 13:05
Copy link
Contributor

@palas palas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@palas palas added this pull request to the merge queue Jun 3, 2024
github-merge-queue bot pushed a commit that referenced this pull request Jun 3, 2024
…-test-watchdog

Use TestWatchdog from hedgehog-extras.
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 3, 2024
@palas palas added this pull request to the merge queue Jun 3, 2024
Merged via the queue into master with commit 4e70e55 Jun 3, 2024
27 checks passed
@palas palas deleted the mgalazyn/test/use-hedgehog-test-watchdog branch June 3, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants