-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test SPOs cannot vote protocol parameter change proposals #5871
Conversation
2477fe7
to
2d2288a
Compare
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Gov/PParamChangeFailsSPO.hs
Outdated
Show resolved
Hide resolved
cardano-testnet/test/cardano-testnet-test/Cardano/Testnet/Test/Gov/DRepActivity.hs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
2d2288a
to
dacbf34
Compare
…function
dacbf34
to
81b4fe8
Compare
proposalFile <- H.note $ baseDir </> "sample-proposal-anchor" | ||
|
||
void $ execCli' execConfig $ | ||
[ "conway", "governance", "action", "create-protocol-parameters-update" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't hardcode "conway"
here. Also food for thought, if we continue implementing functions like this, we are going to have a lot of boiler plate. What about we introduce a callback function that directly modifies the PParamsUpdate ledgerera
type and then serialize to disk?
txIn <- findLargestUtxoForPaymentKey epochStateView sbe wallet | ||
|
||
void $ execCli' execConfig | ||
[ "conway", "transaction", "build" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We shouldn't hardcode "conway"
Description
This PR creates a test that ensures SPOs cannot vote proposals that change protocol parameters. In particular, it tests this by trying to change the DRep activity expiration time and then checking the voting transaction cannot be submitted.
Checklist
See Runnings tests for more details
CHANGELOG.md
for affected package.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7