Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cardano-testnet | Add verification check in stake registration/deregistration test #6026

Merged

Conversation

carbolymer
Copy link
Contributor

Description

Adds checks if the staking address was registered in the ledger.

Follow-up from:

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@carbolymer carbolymer requested a review from a team as a code owner October 29, 2024 17:22
@carbolymer carbolymer force-pushed the mgalazyn/test/add-checks-for-stake-regi-deregistration-test branch from 6e2dd65 to b3ffe47 Compare October 29, 2024 17:25
@carbolymer carbolymer force-pushed the mgalazyn/test/add-checks-for-stake-regi-deregistration-test branch from b3ffe47 to eb09bcf Compare October 30, 2024 09:09
Comment on lines +607 to +609
. L.dsUnifiedL

pure $ L.toStakeCredentials pools
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
. L.dsUnifiedL
pure $ L.toStakeCredentials pools
. L.dsUnifiedL
pure $ L.toStakeCredentials pools

Rationale: being a challenger in nitpick of the year category 😆

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

do we have a leaderbard?

@carbolymer carbolymer added this pull request to the merge queue Nov 12, 2024
Merged via the queue into master with commit 9dbf0b1 Nov 12, 2024
23 checks passed
@carbolymer carbolymer deleted the mgalazyn/test/add-checks-for-stake-regi-deregistration-test branch November 12, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants