Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 10.2.0 #6050

Draft
wants to merge 33 commits into
base: master
Choose a base branch
from
Draft

Release 10.2.0 #6050

wants to merge 33 commits into from

Conversation

neilmayhew
Copy link

Description

Changes for v10.2.0

Closes #6040

Checklist

  • Commit sequence broadly makes sense and commits have useful messages
  • New tests are added if needed and existing tests are updated. These may include:
    • golden tests
    • property tests
    • roundtrip tests
    • integration tests
      See Runnings tests for more details
  • Any changes are noted in the CHANGELOG.md for affected package
  • The version bounds in .cabal files are updated
  • CI passes. See note on CI. The following CI checks are required:
    • Code is linted with hlint. See .github/workflows/check-hlint.yml to get the hlint version
    • Code is formatted with stylish-haskell. See .github/workflows/stylish-haskell.yml to get the stylish-haskell version
    • Code builds on Linux, MacOS and Windows for ghc-8.10.7 and ghc-9.2.7
  • Self-reviewed the diff

Note on CI

If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.

@neilmayhew neilmayhew mentioned this pull request Dec 5, 2024
15 tasks
@crocodile-dentist crocodile-dentist force-pushed the nm/release-srp branch 2 times, most recently from cf9f8a9 to f1a8f7f Compare December 5, 2024 12:08
Comment on lines +182 to +189
args = ConnectToArgs {
ctaHandshakeCodec = codecHandshake forwardingVersionCodec,
ctaHandshakeTimeLimits = timeLimits,
ctaVersionDataCodec = cborTermVersionDataCodec forwardingCodecCBORTerm,
ctaConnectTracers = nullNetworkConnectTracers,
ctaHandshakeCallbacks = HandshakeCallbacks acceptableVersion queryVersion }
Copy link
Contributor

@coot coot Dec 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra space will make things more readable, similar in other places.

Suggested change
args = ConnectToArgs {
ctaHandshakeCodec = codecHandshake forwardingVersionCodec,
ctaHandshakeTimeLimits = timeLimits,
ctaVersionDataCodec = cborTermVersionDataCodec forwardingCodecCBORTerm,
ctaConnectTracers = nullNetworkConnectTracers,
ctaHandshakeCallbacks = HandshakeCallbacks acceptableVersion queryVersion }
args = ConnectToArgs {
ctaHandshakeCodec = codecHandshake forwardingVersionCodec,
ctaHandshakeTimeLimits = timeLimits,
ctaVersionDataCodec = cborTermVersionDataCodec forwardingCodecCBORTerm,
ctaConnectTracers = nullNetworkConnectTracers,
ctaHandshakeCallbacks = HandshakeCallbacks acceptableVersion queryVersion }

@crocodile-dentist crocodile-dentist force-pushed the nm/release-srp branch 3 times, most recently from b14a949 to abd035b Compare December 5, 2024 16:33
@neilmayhew neilmayhew force-pushed the nm/release-srp branch 2 times, most recently from f8e48d4 to f2977ec Compare December 6, 2024 05:16
@jasagredo jasagredo mentioned this pull request Dec 10, 2024
9 tasks
geo2a and others added 4 commits December 12, 2024 16:02
- Categorise `LedgerDB.SnapshotMissingChecksum` trace as `Warning`
- Expose snapshot checksum switch in config file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release v10.2.0
6 participants