-
Notifications
You must be signed in to change notification settings - Fork 721
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 10.2.0 #6050
Draft
neilmayhew
wants to merge
33
commits into
master
Choose a base branch
from
nm/release-srp
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Release 10.2.0 #6050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crocodile-dentist
force-pushed
the
nm/release-srp
branch
2 times, most recently
from
December 5, 2024 12:08
cf9f8a9
to
f1a8f7f
Compare
coot
reviewed
Dec 5, 2024
Comment on lines
+182
to
+189
args = ConnectToArgs { | ||
ctaHandshakeCodec = codecHandshake forwardingVersionCodec, | ||
ctaHandshakeTimeLimits = timeLimits, | ||
ctaVersionDataCodec = cborTermVersionDataCodec forwardingCodecCBORTerm, | ||
ctaConnectTracers = nullNetworkConnectTracers, | ||
ctaHandshakeCallbacks = HandshakeCallbacks acceptableVersion queryVersion } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra space will make things more readable, similar in other places.
Suggested change
args = ConnectToArgs { | |
ctaHandshakeCodec = codecHandshake forwardingVersionCodec, | |
ctaHandshakeTimeLimits = timeLimits, | |
ctaVersionDataCodec = cborTermVersionDataCodec forwardingCodecCBORTerm, | |
ctaConnectTracers = nullNetworkConnectTracers, | |
ctaHandshakeCallbacks = HandshakeCallbacks acceptableVersion queryVersion } | |
args = ConnectToArgs { | |
ctaHandshakeCodec = codecHandshake forwardingVersionCodec, | |
ctaHandshakeTimeLimits = timeLimits, | |
ctaVersionDataCodec = cborTermVersionDataCodec forwardingCodecCBORTerm, | |
ctaConnectTracers = nullNetworkConnectTracers, | |
ctaHandshakeCallbacks = HandshakeCallbacks acceptableVersion queryVersion } | |
crocodile-dentist
force-pushed
the
nm/release-srp
branch
3 times, most recently
from
December 5, 2024 16:33
b14a949
to
abd035b
Compare
neilmayhew
force-pushed
the
nm/release-srp
branch
2 times, most recently
from
December 6, 2024 05:16
f8e48d4
to
f2977ec
Compare
neilmayhew
force-pushed
the
nm/release-srp
branch
from
December 10, 2024 17:45
6a6942e
to
4eb622b
Compare
* ConsensusMode * MinBigLedgerPeersForTrustedState
neilmayhew
force-pushed
the
nm/release-srp
branch
from
December 12, 2024 22:26
d59113c
to
9252209
Compare
- Categorise `LedgerDB.SnapshotMissingChecksum` trace as `Warning` - Expose snapshot checksum switch in config file
…dsToShelleyBasedEra
neilmayhew
force-pushed
the
nm/release-srp
branch
from
December 12, 2024 23:02
9252209
to
222bb5d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changes for v10.2.0
Closes #6040
Checklist
See Runnings tests for more details
CHANGELOG.md
for affected package.cabal
files are updatedhlint
. See.github/workflows/check-hlint.yml
to get thehlint
versionstylish-haskell
. See.github/workflows/stylish-haskell.yml
to get thestylish-haskell
versionghc-8.10.7
andghc-9.2.7
Note on CI
If your PR is from a fork, the necessary CI jobs won't trigger automatically for security reasons.
You will need to get someone with write privileges. Please contact IOG node developers to do this
for you.