Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(#1267): hide the external link button when the metadata fails #1268

Closed
wants to merge 1 commit into from
Closed

feat(#1267): hide the external link button when the metadata fails #1268

wants to merge 1 commit into from

Conversation

MSzalowski
Copy link
Contributor

List of changes

  • hide the external link button when the metadata fails

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Jun 12, 2024 that may be closed by this pull request
Hide external metadata link on DRep Details and Gov Action details when they not pass the validation #1267
Closed
Ryun1
Ryun1 requested changes Jun 12, 2024
View reviewed changes
Copy link
Member

@Ryun1 Ryun1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am against this

see CIP-100 recommendation
"You SHOULD provide a way to access the raw underlying data for advanced or diligent users."

@MSzalowski
Copy link
Contributor Author

@Ryun1 Make sense, thank you so much for your feedback, I'll close this PR 🫡

@MSzalowski MSzalowski closed this Jun 12, 2024
@MSzalowski MSzalowski mentioned this pull request Jun 12, 2024
Closed
@MSzalowski MSzalowski deleted the feat/1267-hide-external-metadata-link-on-drep-details-and-gov-action-details-when-they-not-pass-the-validation branch June 12, 2024 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ryun1 Ryun1 Ryun1 requested changes

@Sworzen1 Sworzen1 Sworzen1 approved these changes

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hide external metadata link on DRep Details and Gov Action details when they not pass the validation
3 participants
@MSzalowski @Ryun1 @Sworzen1