Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test stack deployment fixes #1270

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Test stack deployment fixes #1270

merged 4 commits into from
Jun 13, 2024

Conversation

mesudip
Copy link
Contributor

@mesudip mesudip commented Jun 13, 2024

List of changes

  • Add sentry configuration for frontend and backend in test stack

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@mesudip mesudip requested a review from NabinKawan June 13, 2024 03:39
@mesudip mesudip mentioned this pull request Jun 13, 2024
Closed
2 tasks
NabinKawan
NabinKawan approved these changes Jun 13, 2024
View reviewed changes
Copy link
Contributor

@NabinKawan NabinKawan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mesudip mesudip force-pushed the infra/test-chores branch from bae67cd to a1dac9b Compare June 13, 2024 04:49
@mesudip mesudip merged commit 025462d into develop Jun 13, 2024
1 check passed
@mesudip mesudip deleted the infra/test-chores branch June 13, 2024 05:05
@pmbinapps pmbinapps mentioned this pull request Jun 14, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NabinKawan NabinKawan NabinKawan approved these changes

@placek placek Awaiting requested review from placek placek is a code owner

@adgud adgud Awaiting requested review from adgud

@Ryun1 Ryun1 Awaiting requested review from Ryun1 Ryun1 is a code owner

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mesudip @NabinKawan