Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/141-create-a-sole-voter-card #197

Merged
merged 20 commits into from
Feb 19, 2024
Merged

feat/141-create-a-sole-voter-card #197

merged 20 commits into from
Feb 19, 2024

Conversation

Sworzen1
Copy link
Contributor

@Sworzen1 Sworzen1 commented Feb 16, 2024 •
edited
Loading

List of changes

  • Add sole voter card

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@Sworzen1 Sworzen1 added the 🖥 Frontend Frontend related label Feb 16, 2024
@Sworzen1 Sworzen1 linked an issue Feb 16, 2024 that may be closed by this pull request
Create a sole voter card #141
Closed
@Sworzen1 Sworzen1 changed the base branch from develop to feat/143-create-a-sole-voter-information-page February 16, 2024 13:40
@Sworzen1 Sworzen1 marked this pull request as ready for review February 16, 2024 13:40
@MSzalowski MSzalowski force-pushed the feat/143-create-a-sole-voter-information-page branch from 6958873 to 11bd441 Compare February 16, 2024 14:43
@MSzalowski MSzalowski force-pushed the feat/141-create-a-sole-voter-card branch from 27a5ae6 to 68571dc Compare February 16, 2024 14:43
MSzalowski
MSzalowski approved these changes Feb 19, 2024
View reviewed changes
govtool/frontend/src/components/organisms/DashboardCards.tsx Outdated
{/* DREP CARD END*/}
{/* SOLE VOTER CARD */}
<DashboardActionCard
dataTestidFirstButton={"register-as-sole-voter-button"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfiy string props. Here you have them in curly braces and below you are passing them with quotation marks

@Sworzen1 Sworzen1 changed the base branch from feat/143-create-a-sole-voter-information-page to feat/119-i-want-to-vote-on-behalf-of-myself-become-a-drep February 19, 2024 14:18
@JanJaroszczak JanJaroszczak merged commit 2759509 into feat/119-i-want-to-vote-on-behalf-of-myself-become-a-drep Feb 19, 2024
1 check passed
@JanJaroszczak JanJaroszczak deleted the feat/141-create-a-sole-voter-card branch February 19, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MSzalowski MSzalowski MSzalowski approved these changes

@JanJaroszczak JanJaroszczak Awaiting requested review from JanJaroszczak

@kickloop kickloop Awaiting requested review from kickloop

Assignees
No one assigned
Labels
🖥 Frontend Frontend related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a sole voter card
3 participants
@Sworzen1 @MSzalowski @JanJaroszczak