Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable and Display dRep Voting for All Governance Actions in Testing #2552

Merged
merged 4 commits into from
Jan 2, 2025
Merged

Enable and Display dRep Voting for All Governance Actions in Testing #2552

merged 4 commits into from
Jan 2, 2025

Conversation

kneerose
Copy link
Contributor

List of changes

Note: This PR is ready to be merged once Issue #2527 is resolved.

  • Removed unnecessary "view first dRep vote enabled" function
  • Enabled vote display for all governance actions in full governance.
  • Removed restrictions and ensured all governance actions are checked for dRep-dependent tests.

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@kneerose kneerose requested a review from mesudip December 18, 2024 06:33
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@kneerose kneerose force-pushed the bugfix/dRep-vote-dependent-test branch from 39902f3 to 76d11b2 Compare December 23, 2024 11:08
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

✅ All checks succeeded

mesudip
mesudip approved these changes Jan 2, 2025
View reviewed changes
Copy link
Contributor

@mesudip mesudip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kneerose kneerose merged commit 82ae303 into develop Jan 2, 2025
10 checks passed
@kneerose kneerose deleted the bugfix/dRep-vote-dependent-test branch January 2, 2025 08:47
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

@kneerose
This PR is in the tag: develop-82ae303762d5e89b11e2073c13133e95435670cc , for govtool-metadata-validation service

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

@kneerose
This PR is in the tag: develop-82ae303762d5e89b11e2073c13133e95435670cc , for govtool-frontend service

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

@kneerose
This PR is in the tag: develop-82ae303762d5e89b11e2073c13133e95435670cc , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mesudip mesudip mesudip approved these changes

@MSzalowski MSzalowski Awaiting requested review from MSzalowski MSzalowski is a code owner

@jdyczka jdyczka Awaiting requested review from jdyczka jdyczka is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kneerose @mesudip