Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(#2583): fix encoding and decoding cip-129 drep_script identifiers #2595

Merged
merged 2 commits into from
Jan 3, 2025
Merged

fix(#2583): fix encoding and decoding cip-129 drep_script identifiers #2595

merged 2 commits into from
Jan 3, 2025

Conversation

MSzalowski
Copy link
Contributor

@MSzalowski MSzalowski commented Jan 1, 2025 •
edited
Loading

List of changes

  • fix encoding and decoding CIP-129 drep_script identifiers

Checklist

  • related issue
  • My changes generate no new warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the changelog
  • I have added tests that prove my fix is effective or that my feature works

@MSzalowski MSzalowski linked an issue Jan 1, 2025 that may be closed by this pull request
[USERSNAP] We registered our drep unsing mesh multisig and everything worked flawless. https://cardanoscan.io/drep/drep1ydwtnlvdd8atlj5c5ylgw4kg5e640vyt8resattrjmwufyg4qclf7 However we are not listed on gov tools which is raver disappointing. Could this... #2583
Closed
@MSzalowski MSzalowski requested a review from placek January 1, 2025 15:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 1, 2025

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 1, 2025

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 1, 2025

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

✅ All checks succeeded

@MSzalowski MSzalowski force-pushed the fix/2583-wrong-drep-script-cip-129-identifier-generation branch from 2712685 to 67a199f Compare January 2, 2025 13:55
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

✅ All checks succeeded

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

✅ All checks succeeded

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2025

✅ All checks succeeded

@MSzalowski MSzalowski merged commit 788a20c into develop Jan 3, 2025
13 of 18 checks passed
@MSzalowski MSzalowski deleted the fix/2583-wrong-drep-script-cip-129-identifier-generation branch January 3, 2025 12:43
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

@MSzalowski
This PR is in the tag: develop-788a20cbeae9acc2507541f904d737255b48fc17 , for govtool-metadata-validation service

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

@MSzalowski
This PR is in the tag: develop-788a20cbeae9acc2507541f904d737255b48fc17 , for govtool-frontend service

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

@MSzalowski
This PR is in the tag: develop-788a20cbeae9acc2507541f904d737255b48fc17 , for govtool-backend service

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ryun1 Ryun1 Ryun1 left review comments

@placek placek placek approved these changes

@jdyczka jdyczka Awaiting requested review from jdyczka jdyczka is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@MSzalowski @placek @Ryun1