Skip to content

Conversation

wenkokke
Copy link
Collaborator

No description provided.

* withSession (simple & full)
* closeSession (simple & full)
* withTable (full)
* closeTable (full)
Copy link
Collaborator

@jeltsch jeltsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since I’m not that familiar with these things, I can’t be very sure that everything is correct, but based on my knowledge I didn’t find any errors. Also, the prose is much clearer now.

The worst-case disk I\/O complexity of this operation depends on the merge policy of the table:
['LazyLevelling']:
\(O(T \log_T \frac{n}{B})\).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The n can be slightly confusing here. Maybe it would help to mention that it refers to the size of the table at the end of the action that is performed on the empty table?

Copy link
Collaborator

@dcoutts dcoutts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenkokke wenkokke added this pull request to the merge queue May 19, 2025
Merged via the queue into main with commit 0dec006 May 19, 2025
28 checks passed
@wenkokke wenkokke deleted the wenkokke/fix-diskio-cost branch May 19, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants