[Builtins] Allow casing on booleans #7029
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
effectfully
force-pushed
the
effectfully/builtins/allow-casing-on-booleans
branch
from
8358a8f to
5244c96
Compare
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
effectfully
force-pushed
the
effectfully/builtins/allow-casing-on-booleans
branch
from
5244c96 to
8b55532
Compare
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
effectfully
force-pushed
the
effectfully/builtins/allow-casing-on-booleans
branch
from
8b55532 to
2344b92
Compare
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
effectfully
force-pushed
the
effectfully/builtins/allow-casing-on-booleans
branch
from
2344b92 to
c0df0c1
Compare
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
|
/benchmark nofib |
1 similar comment
|
/benchmark nofib |
|
/benchmark lists |
1 similar comment
|
/benchmark lists |
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'nofib' on '27d2bc3905' (base) and 'c0df0c158b' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'nofib' on '27d2bc3905' (base) and 'c0df0c158b' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on '27d2bc3905' (base) and 'c0df0c158b' (PR) Results table
|
|
Click here to check the status of your benchmark. |
|
Comparing benchmark results of 'lists' on '27d2bc3905' (base) and 'c0df0c158b' (PR) Results table
|
effectfully
force-pushed
the
effectfully/builtins/allow-casing-on-booleans
branch
from
c0df0c1 to
06d1a16
Compare
…to effectfully/builtins/allow-casing-on-booleans
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
…to effectfully/builtins/allow-casing-on-booleans
effectfully
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Unisay
reviewed
Apr 30, 2025
Unisay
reviewed
Apr 30, 2025
| . PIR.lamAbs () b (PLC.mkTyBuiltin @_ @Bool ()) | ||
| . PIR.lamAbs () x (PLC.TyVar () a) | ||
| . PIR.lamAbs () y (PLC.TyVar () a) | ||
| $ PIR.kase () |
effectfully
commented
May 1, 2025
| @@ -211,6 +210,8 @@ program | |||
| (\v -> List (Tuple2 PredKey (List v))) Rational -> ParamValue | |||
| in | |||
| let | |||
| !ifThenElse : all a. bool -> a -> a -> a | |||
| = /\a -> \(b : bool) (x : a) (y : a) -> case a b [y, x] | |||
There was a problem hiding this comment.
I checked, the corresponding UPLC doesn't mention ifThenElse anywhere (that binding here is dead).
I also checked the unconditionally inlining ifThenElse isn't a good idea: if it's not saturated we get worst performance and if it's saturated we get the same performance (because it's inlined in UPLC anyway).
| let | ||
| !x : integer = multiplyInteger n d' | ||
| !y : integer = multiplyInteger n' d | ||
| in |
There was a problem hiding this comment.
Weird that it stopped inlining. I checked, it's because of ifThenElse not inlining. But still weird.
Comment on lines
0
to
1
| ExBudget {exBudgetCPU = ExCPU 856122341, exBudgetMemory = ExMemory 4215188} No newline at end of file | ||
| ExBudget {exBudgetCPU = ExCPU 660323564, exBudgetMemory = ExMemory 3405515} |
There was a problem hiding this comment.
-22.9% CPU, -19.2% MEM.
Comment on lines
0
to
1
| ExBudget {exBudgetCPU = ExCPU 82853157, exBudgetMemory = ExMemory 359405} No newline at end of file | ||
| ExBudget {exBudgetCPU = ExCPU 66780110, exBudgetMemory = ExMemory 307802} |
There was a problem hiding this comment.
-19.4% CPU, -14.4% MEM.
Comment on lines
0
to
1
| ExBudget {exBudgetCPU = ExCPU 540900171, exBudgetMemory = ExMemory 2593218} No newline at end of file | ||
| ExBudget {exBudgetCPU = ExCPU 472454709, exBudgetMemory = ExMemory 2373180} |
There was a problem hiding this comment.
-12.7% CPU, -8.5% MEM.
Comment on lines
9
to
11
| force | ||
| (force ifThenElse | ||
| (case | ||
| (equalsData obsScriptCred wdrlAtZero) |
There was a problem hiding this comment.
This is definitely safe to optimize, we know the exact type that equalsData returns. But I'm not sure if it's worth doing it instead of the more general optimization pushing force into any kind of case having delay in its branches.
Comment on lines
12
to
+16
| Bool_match | ||
| (ifThenElse | ||
| {Bool} | ||
| (case | ||
| Bool | ||
| (equalsData r_stake_cred (fstPair {data} {data} p)) | ||
| True | ||
| False) | ||
| [False, True]) |
There was a problem hiding this comment.
Anyway, we should stop converting between the two representations of Bool now that the built-in one should be about as efficient as SOP.
Comment on lines
0
to
1
| 1960 No newline at end of file | ||
| 1798 |
Comment on lines
0
to
3
| cpu: 441439 | ||
| mem: 2102 | ||
| size: 32 No newline at end of file | ||
| cpu: 285390 | ||
| mem: 1601 | ||
| size: 24 |
…to effectfully/builtins/allow-casing-on-booleans
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for casing on booleans and integers using
Case, which is the first part of #6602.