Added a timezone object to the datetime object generated in cql_to_py for timestamps #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronharel02
changed the title
ronharel02
changed the title
ronharel02
changed the title
|
I would disagree with this change, because timestamps are generally timezone independent. https://stackoverflow.com/a/23062640 You can always assume that returned datetime in UTC. So, instead of calculating an offset, you can set it statically to UTC. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this is a good addition for situations where timestamps queried from the database need to be compared with
datetimeobjects acquired from other sources that may be set to a different timezone.I'm not very acquainted with PyO3 so this can probably be implemented in a cleaner way... I would love to help improve this addition :)