Use Dagger for dependency injection #36
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I stopped short of ViewModel injection and only inject up to the activity/fragment level since having Dagger work with ViewModelProvider will introduce additional complexity, especially if we also want to support passing in additional data that are outside of Dagger graph such as intent extras. Right now the Dagger setup is relatively simple while still allowing the main feature of configuring the dependency graph.
f2rf2r
requested review from
gdaniels,
shadow7,
russhwolf,
streetsofboston and
mpeng3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I stopped short of ViewModel injection and only inject up to the activity/fragment level since having Dagger work with ViewModelProvider will introduce additional complexity, especially if we also want to support passing in additional data that are outside of Dagger graph such as intent extras. Right now the Dagger setup is relatively simple while still allowing the main feature of configuring the dependency graph.
I'm planning on also creating another PR for Kodein. My plan is to have one of them to merge into master and become the default, and the other one will stay as a separate branch and periodically merge the latest changes from master.