Added entity type as a condition #71
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have yet to test this lmao
PeachesMLG
reviewed
Jul 28, 2024
Comment on lines
12
to
16
| for (String entityType : entities) { | ||
| if (checkEntityType(target, entityType, operator)) { | ||
| return true; | ||
| } | ||
| } |
There was a problem hiding this comment.
I dont believe this will work, lets say the Target is a Creeper, and we have ENTITYTYPE != ZOMBIE, CREEPER
It will loop over ZOMBIE, CREEPER it will say Zombie != Creeper it will return true. But it will never evaluate the second one Creeper != Creeper Which is falke
So for the == condition, we want any of them to match (what we have already) but for != we want all of them to match
|
Frick, wrong pr.... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have yet to test this lmao