-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Island Level Configuration #818
Conversation
sh0inx
commented
Mar 1, 2024
- the other side of IridiumTeams #49
- the other side of [IridiumTeams #49](Iridium-Development/IridiumTeams#49)
- added ``minLevel`` to ``BiomeItem`` and ``SchematicConfig`` classes, and functionality to use them - added ``islandCreationCost`` in config to check if we want islands to cost something on creation or just regen - updated configs to reflect changes in teams (also updated default regenCost to be 0 because... y'know) - removed formulas from ``getLevel()`` because we pull from islandManager instead - added ``island_experienceToLevelUp`` and ``island_experienceForNextLevel`` placeholders, which return the amount of experience left needed to level up and the experience needed for the next level respectively
@@ -56,6 +56,7 @@ public Configuration() { | |||
public boolean clearEnderChestOnRegen = false; | |||
public boolean allowPvPOnIslands = false; | |||
public boolean islandCreateOnJoin = false; | |||
public boolean islandCreationCost = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this is going to confuse things even more. I understand there are alot of people asking this in the Discord, but if we want to remove the creation cost, I feel setting the default cost to 0 for everything is a better aproach
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was more for the fact that we could allow pricing for creation and regen to be different (as in, when you create the island, it doesn't cost anything, but when you regen, it does) - we could change it to be free but honestly i dont care about those people lol
@@ -61,7 +62,7 @@ public void addContent(Inventory inventory) { | |||
|
|||
private List<Placeholder> getBiomeLorePlaceholders(Biomes.BiomeItem item) { | |||
List<Placeholder> placeholders = new ArrayList<>(Arrays.asList( | |||
new Placeholder("amount", IridiumSkyblock.getInstance().getBiomeManager().formatPrice(item.defaultAmount)), | |||
new Placeholder("minLevel", String.valueOf(item.minLevel)), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we not need the Amount placeholder anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this allows us to fetch the price of the schematic from the config directly without having to set the lore manually every time
src/main/java/com/iridium/iridiumskyblock/managers/BiomeManager.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Peaches_MLG <[email protected]>