added more placeholders #821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- modified the fetch for online and offline members to run a single stream to create both lists - added ``island_visitors`` and ``island_visitors_amount`` placeholders to get the list of player names visiting an island and the amount of current visitors to said island - added ``island_booster`` and ``island_upgrade`` placeholders, to get whether they're active, the level of the enhancement, and the time remaining
- also removed members from the list of visitors
- fixed an error in loop logic
…ceholders # Conflicts: # src/main/java/com/iridium/iridiumskyblock/placeholders/IslandPlaceholderBuilder.java
PeachesMLG
approved these changes
May 10, 2024
Comment on lines
38
to
39
| if(user.getPlayer() != null) onlineUsers.add(user.getName()); | ||
| else offlineUsers.add(user.getName()); |
There was a problem hiding this comment.
Suggested change
| if(user.getPlayer() != null) onlineUsers.add(user.getName()); | |
| else offlineUsers.add(user.getName()); | |
| if (user.getPlayer() != null) { | |
| onlineUsers.add(user.getName()); | |
| } else { | |
| offlineUsers.add(user.getName()); | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
island_visitorsandisland_visitors_amountplaceholders to get the list of player names visiting an island and the amount of current visitors to said islandisland_boosterandisland_upgradeplaceholders, to get whether they're active, the level of the enhancement, and the time remaining