Updates for the VirtualBox.ExtensionPack chocolatey package. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The VBoxManage install command was returning the percentage progress via stderr, which caused chocolatey to assume failure (even though it did install the ExtensionPack successfully). This fix captures the stdout/stderr, then either displays it on success or uses it as an exception message on failure, which causes chocolatey to correctly determine success or failure of the VB ExtensionPack installation.
Update the VirtualBox.ExtensionPack chocolatey package from v4.3.16.95972 to v4.3.28.100309.
Update the VirtualBox.ExtensionPack chocolatey package from v4.3.28.100309 to v5.0.0.101573.
Remove the use of functions in the Chocolatey install/uninstall scripts. Since these scripts are generally pretty simple and nothing is being called more than once and also is not modularized, it is probably simplest to not use functions at all.
Instead of pushing/popping the temp Extension Pack download path, just use the full path in the VBoxManage install command. This should ensure that users don't end up in a different path if the VBoxManage extension pack install command fails.
The .nuspec should use UTF-8 without BOM and the .ps1 files should use UTF-8 with BOM.
Previously, the VBoxManage.exe (that is included with VirtualBox) was found using the Get-Command cmdlet (followed by defaulting to PROGRAMFILES\Oracle\VirtualBox), but now we check through locations in each of these sources, in this order: -VBOX_MSI_INSTALL_PATH environment variable -PATH environment variable -PROGRAMFILES(x86)\Oracle\VirtualBox\ -PROGRAMFILES\Oracle\VirtualBox\
Add 'Michael Ray' as an author for the VirtualBox.ExtensionPack chocolatey package & also add some comments to the install/uninstall scripts.
Make the dependency on the 'virtualbox' package version-specific so the Extension Pack isn't used with older/newer (major) versions of VirtualBox.
Update the VirtualBox.ExtensionPack chocolatey package from v5.0.0.101573 to v5.0.2.102096.
Update the VirtualBox.ExtensionPack chocolatey package from v5.0.2.102096 to v5.0.4.102546.
Update the VirtualBox.ExtensionPack chocolatey package from v5.0.4.102546 to v5.0.6.103037.
Fix for errors when a path in the PATH environment variable uses a drive letter that doesn't exist. The Join-Path cmdlet does checking for non-existent drives while [IO.File]::Combine() does not.
Update the VirtualBox.ExtensionPack chocolatey package from v5.0.6.103037 to v5.0.8.103449.
Update the VirtualBox.ExtensionPack chocolatey package from v5.0.8.103449 to v5.0.10.104061.
Update the VirtualBox.ExtensionPack chocolatey package from v5.0.10.104061 to v5.0.12.104815.
Update the VirtualBox.ExtensionPack chocolatey package from v5.0.12.104815 to v5.0.14.105127.
Update the VirtualBox.ExtensionPack chocolatey package from v5.0.14.105127 to v5.0.16.105871.
To avoid issues with VirtualBox being installed during this same session, then the VB install path not being found in the environment var(s), refresh the PS session before finding installation paths.
Update the VirtualBox.ExtensionPack chocolatey package from v5.0.16.105871 to v5.0.20.106931.
Update the VirtualBox.ExtensionPack chocolatey package from v5.0.20.106931 to v5.0.22.108108.
Update the VirtualBox.ExtensionPack chocolatey package from v5.0.22.108108 to v5.0.24.108355.
Update the VirtualBox.ExtensionPack chocolatey package from v5.0.24.108355 to v5.1.0.108711.
Update the VirtualBox.ExtensionPack chocolatey package from v5.1.0.108711 to v5.1.2.108956.
Update the VirtualBox.ExtensionPack chocolatey package from v5.1.2.108956 to v5.1.4.110228.
Update the .nuspec for this Chocolatey package to add the Guidelines/Suggestions info from the automated validation: -packageSourceUrl: URL where the Chocolatey package source resides. -docsUrl: URL of the wiki or docs of the software. -mailingListUrl: URL of the forum or email list group for the software. -bugTrackerUrl: URL to location where issues/tickets can be accessed. -projectSourceUrl: URL to the underlying software source.
Add the SHA256 checksum of the downloaded/installed VirtualBox.ExtensionPack file.
Update the VirtualBox.ExtensionPack chocolatey package from v5.1.4.110228 to v5.1.6.110634.
Update the VirtualBox.ExtensionPack chocolatey package from v5.1.6.110634 to v5.1.8.111374.
Update package version for VirtualBox.ExtensionPack chocolatey package to match the upstream virtualbox package, even though the actual version of VirtualBox and the extension pack did not change.
Update the VirtualBox.ExtensionPack chocolatey package from v5.1.8.20161116 to v5.1.10.
Update the VirtualBox.ExtensionPack chocolatey package from v5.1.10 to v5.1.10.112026.
Deprecate the VirtualBox.ExtensionPack chocolatey package at 5.1.10.20161223, since the extension pack is now installed via the upstream dependency virtualbox package.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.