Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New MultilinearPolyVariant for multilinear extensions of composites #61

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

New MultilinearPolyVariant for multilinear extensions of composites #61

wants to merge 1 commit into from
+364 −25

Conversation

TomWambsgans
Copy link
Contributor

Attempt to fix #40

@TomWambsgans
Copy link
Contributor Author

TomWambsgans commented Mar 2, 2025 •
edited
Loading

NOT ready for merge: even though the new evalcheck test pass, it doesnt work end to end on this project (cargo run panics on Evalcheck(Evalcheck(Verification(IncorrectEvaluation("Composition: merkle_table::pre_hash_main"))))) . Investigation in progress

@jimpo-ulvt
Copy link
Contributor

Nice job!! I'll review when it passes for your project. Please let me know if you need help investigating/debugging.

fkondej
fkondej previously approved these changes Mar 2, 2025
View reviewed changes
@fkondej fkondej self-requested a review March 2, 2025 12:19
@fkondej fkondej dismissed their stale review March 2, 2025 12:21

miss clicked

@TomWambsgans
Copy link
Contributor Author

My mistake is that I've built a "true" composition of multilinears, instead of the MLE of the evaluations of a composition of multlinears on the hypercube. Should be fixed in the coming days

@jimpo-ulvt
Copy link
Contributor

My mistake is that I've built a "true" composition of multilinears, instead of the MLE of the evaluations of a composition of multlinears on the hypercube. Should be fixed in the coming days

Yes, exactly. Let me know if you have questions about how to implement that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jimpo-ulvt jimpo-ulvt Awaiting requested review from jimpo-ulvt jimpo-ulvt is a code owner

@onesk onesk Awaiting requested review from onesk onesk is a code owner

@fkondej fkondej Awaiting requested review from fkondej

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New MultilinearPolyVariant for multilinear extensions of composites
3 participants
@TomWambsgans @jimpo-ulvt @fkondej