Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci]: Setup rust as pre run & allow deadcode #76

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

milosbackonja
Copy link
Contributor

No description provided.

@milosbackonja milosbackonja force-pushed the mbackonja/ci-nightly-fix branch from 967cc35 to 4616e83 Compare March 3, 2025 20:25
@milosbackonja milosbackonja marked this pull request as ready for review March 3, 2025 20:37
@milosbackonja milosbackonja requested review from a team, jimpo-ulvt and onesk as code owners March 3, 2025 20:37
@GraDKh
Copy link
Contributor

GraDKh commented Mar 4, 2025

It's weird, but when I'm running the clippy command locally it doesn't pass:

cargo clippy --all --all-features --tests --benches --examples -- -D warnings

This is actually because we have a feature stable_only with which we currently can't compile all the crate. I suppose we shouldn't run clippy with --all-features and pick some reasonable subset

@jimpo-ulvt jimpo-ulvt merged commit bba1d39 into main Mar 4, 2025
17 checks passed
@jimpo-ulvt jimpo-ulvt deleted the mbackonja/ci-nightly-fix branch March 4, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants