Skip to content
This repository has been archived by the owner on Sep 4, 2024. It is now read-only.

[Deno Compatability] fix: source avsc from npm #73

Closed
wants to merge 2 commits into from

Conversation

zakkvry
Copy link

@zakkvry zakkvry commented May 16, 2023

Experiencing a resolution issue for avsc when trying to use Deno + Metaplex who depends on this lib.

fwiw; 3 tests are failing before & after the change

Screenshot from 2023-05-16 14-44-35

@JesseTheRobot
Copy link
Member

Hey @zakkvry , Arbundles no longer uses AVSC in production code, only as part of tests - It looks like the version of Arbundles MetaPlex is using is out of date. They'll need to update on their end in order to fix this issue.

@zakkvry
Copy link
Author

zakkvry commented May 16, 2023

Hey @JesseTheRobot thanks for checking! Looks like in between Metaplex and this package this is one @bundlr-network/client -> https://github.com/Bundlr-Network/js-sdk/blob/main/package.json

Screenshot from 2023-05-16 15-03-56

I pushed another change - to move avsc to devDependencies. I suspect without this, anyone depending on @bundlr-network/client will incur an NPM download of avsc unnecessarily.

@JesseTheRobot
Copy link
Member

@zakkvry Metaplex is using a now months old version of our client package - they need to update the version on their end, and then your problem will be solved. I would suggest creating an issue to this effect here.
While it is possible to change the AVSC dependency via a backport patch, this will break arbundles for specific users (tl;dr regular AVSC isn't compatible with CSP), and so doing this not viable.
As of the latest version, AVSC is already a dev dependency.
If you do submit an issue, feel free to link it here - I'll track & support it as I am able.

@zakkvry
Copy link
Author

zakkvry commented May 16, 2023

Will do, thanks a lot @JesseTheRobot :)

@zakkvry zakkvry closed this May 16, 2023
@zakkvry
Copy link
Author

zakkvry commented May 16, 2023

@JesseTheRobot metaplex-foundation/js#518

@zakkvry
Copy link
Author

zakkvry commented May 16, 2023

think they might need help with breaking changes?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants