Implements sooner resource validity checking

crates/hyperqueue/src/client/commands/submit/command.rs

@@ -465,12 +465,13 @@ impl JobSubmitOpts {
                 },
             )
         }
-
-        Ok(ResourceRequest {
+        let request = ResourceRequest {
             n_nodes: self.conf.nodes,
             min_time: self.conf.time_request,
             resources,
-        })
+        };
+        request.validate()?;
+        Ok(request)
     }
 }
 

crates/tako/src/gateway.rs

@@ -1,5 +1,6 @@
 use serde::{Deserialize, Serialize, Serializer};
 
+use crate::internal::common::error::DsError;
 use crate::internal::messages::common::TaskFailInfo;
 use crate::internal::messages::worker::WorkerOverview;
 use crate::internal::worker::configuration::WorkerConfiguration;
@@ -44,6 +45,23 @@ impl Default for ResourceRequest {
     }
 }
 
+impl ResourceRequest {
+    pub fn validate(&self) -> crate::Result<()> {
+        for (i, entry) in self.resources.iter().enumerate() {
+            entry.policy.validate()?;
+            for entry2 in &self.resources[i + 1..] {
+                if entry.resource == entry2.resource {
+                    return Err(DsError::GenericError(format!(
+                        "Resource '{}' defined more than once",
+                        entry.resource
+                    )));
+                }
+            }
+        }
+        Ok(())
+    }
+}
+
 #[derive(Serialize, Deserialize, Debug, PartialEq, Eq, Hash, Clone)]
 pub struct ResourceRequestVariants {
     pub variants: SmallVec<[ResourceRequest; 1]>,

tests/test_resources.py

@@ -456,3 +456,16 @@ def test_manual_cpu_resource_sum(hq_env: HqEnv):
         args=["worker", "start", "--resource", "cpus=sum(5)"],
         expect_fail="Resource kind `sum` cannot be used with CPUs",
     )
+
+
+def test_resources_invalid_definitions(hq_env: HqEnv):
+    hq_env.start_server()
+    hq_env.command(
+        args=["submit", "--resource", "foo=10", "--resource", "foo=1", "--", "sleep", "1"],
+        expect_fail="Resource 'foo' defined more than once",
+    )
+
+    hq_env.command(
+        args=["submit", "--resource", "foo=0", "--", "sleep", "1"],
+        expect_fail="Zero resources cannot be requested",
+    )