Skip to content

[MOB-11436] Android: add serialization of placements #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: evan/MOB-7936-iterable-embedded-message-class
Choose a base branch
from

Conversation

evantk91
Copy link
Contributor

@evantk91 evantk91 commented Jun 6, 2025

🔹 JIRA Ticket(s) if any

✏️ Description

This pull request adds the calling of the native function and the serialization of the embedded messages into a JSON array.

Testing:

  • test using the dev app, click "get embedded messages" in api list and you should be able to verify that embedded messages are printed out to the terminal

@evantk91 evantk91 marked this pull request as draft June 6, 2025 23:19
…MOB-11436-add-serialization-of-placements-android
Copy link

github-actions bot commented Jun 6, 2025

Lines Statements Branches Functions
Coverage: 45%
44.69% (236/528) 20.7% (41/198) 38.37% (66/172)

Evan Greer added 2 commits June 7, 2025 08:07
@evantk91 evantk91 changed the base branch from evan/MOB-11561-enableEmbeddedMessaging-flag to evan/MOB-7936-iterable-embedded-message-class June 9, 2025 19:49
Copy link

codeclimate bot commented Jun 9, 2025

❌ 1 blocking issue (1 total)

Tool Category Rule Count
eslint Lint tsdoc-param-tag-with-invalid-type: The @param block should not include a JSDoc-style '{type}' 1

This is from Qlty Cloud, the successor to Code Climate Quality. Learn more.

@evantk91 evantk91 marked this pull request as ready for review June 10, 2025 20:18
@evantk91 evantk91 marked this pull request as draft June 11, 2025 18:39
@@ -14,11 +14,14 @@ export class IterableEmbeddedManager {
/**
* Retrieve the current user's list of embedded placements.
*
* @param {number} placementId The ID of the placement to retrieve messages from.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsdoc-param-tag-with-invalid-type: The @param block should not include a JSDoc-style '{type}' [eslint:tsdoc/syntax]

@@ -14,11 +14,14 @@ export class IterableEmbeddedManager {
/**
* Retrieve the current user's list of embedded placements.
*
* @param {number} placementId The ID of the placement to retrieve messages from.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tsdoc-param-tag-with-invalid-type: The @param block should not include a JSDoc-style '{type}' [eslint:tsdoc/syntax]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant