[MOB-11551] creates IterableEmbeddedMessageElements class #656
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
evantk91
changed the title
❌ 7 blocking issues (10 total)
This is from Qlty Cloud, the successor to Code Climate Quality. Learn more. |
lposen
reviewed
Jun 9, 2025
| * An interface defining the dictionary object containing the properties for the embedded message default action. | ||
| */ | ||
| export interface EmbeddedMessageDefaultActionDict { | ||
| type: string; |
There was a problem hiding this comment.
Please add comments to the props
lposen
reviewed
Jun 9, 2025
| * An interface defining the dictionary object containing the properties for the embedded message elements. | ||
| */ | ||
| export interface EmbeddedMessageElementsDict { | ||
| title?: string; |
There was a problem hiding this comment.
Please add comments to the props
lposen
reviewed
Jun 9, 2025
| * An interface defining the dictionary object containing the properties for an embedded message text. | ||
| */ | ||
| export interface EmbeddedMessageTextDict { | ||
| id: string; |
There was a problem hiding this comment.
Please add comments to the props
lposen
reviewed
Jun 9, 2025
| /** | ||
| * IterableEmbeddedMessageText represents a text element in an embedded message. | ||
| */ | ||
| export class IterableEmbeddedMessageText { |
There was a problem hiding this comment.
I feel like a lot of these don't necessarily need to be classes, and that they could just be interfaces. But I'll have to double check how they all fit together.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔹 JIRA Ticket(s) if any
✏️ Description