Skip to content

feat: migrate AppDelegate to Swift and remove legacy files for improved architecture #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 10 commits into
base: new-arch/master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
72 changes: 38 additions & 34 deletions Iterable-React-Native-SDK.podspec
Original file line number Diff line number Diff line change
@@ -1,44 +1,48 @@
# require "json"

# package = JSON.parse(File.read(File.join(__dir__, "package.json")))

# Pod::Spec.new do |s|
# s.name = "Iterable-React-Native-SDK"
# s.version = package["version"]
# s.summary = package["description"]
# s.homepage = package["homepage"]
# s.license = package["license"]
# s.authors = package["author"]

# s.platforms = { :ios => min_ios_version_supported }
# s.source = { :git => "https://github.com/Iterable/react-native-sdk.git", :tag => "#{s.version}" }

# s.source_files = "ios/**/*.{h,m,mm,swift}"

# s.dependency "Iterable-iOS-SDK", "6.5.4"
# # React Native Core dependency
# install_modules_dependencies(s)

# end

require "json"

package = JSON.parse(File.read(File.join(__dir__, "package.json")))
folly_compiler_flags = '-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1 -Wno-comma -Wno-shorten-64-to-32'

Pod::Spec.new do |s|
s.name = "Iterable-React-Native-SDK"
s.version = package["version"]
s.summary = package["description"]
s.homepage = package["homepage"]
s.license = package["license"]
s.authors = package["author"]

# Default fields for a valid podspec
s.name = "Iterable-React-Native-SDK"
s.version = package["version"]
s.summary = package["description"]
s.description = package["description"]
s.homepage = package["homepage"]
s.license = package["license"]
s.platforms = { :ios => min_ios_version_supported }
# s.platforms = { :ios => "11.0" }
s.author = package["author"]
s.source = { :git => "https://github.com/Iterable/react-native-sdk.git", :tag => "#{s.version}" }

s.source_files = "ios/**/*.{h,m,mm,swift}"

# Use install_modules_dependencies helper to install the dependencies if React Native version >=0.71.0.
# See https://github.com/facebook/react-native/blob/febf6b7f33fdb4904669f99d795eba4c0f95d7bf/scripts/cocoapods/new_architecture.rb#L79.
if respond_to?(:install_modules_dependencies, true)
install_modules_dependencies(s)
else
s.dependency "React-Core"

# Don't install the dependencies when we run `pod install` in the old architecture.
if ENV['RCT_NEW_ARCH_ENABLED'] == '1' then
s.compiler_flags = folly_compiler_flags + " -DRCT_NEW_ARCH_ENABLED=1"
s.pod_target_xcconfig = {
"HEADER_SEARCH_PATHS" => "\"$(PODS_ROOT)/boost\"",
"OTHER_CPLUSPLUSFLAGS" => "-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1",
"CLANG_CXX_LANGUAGE_STANDARD" => "c++17"
}
s.dependency "React-Codegen"
s.dependency "RCT-Folly"
s.dependency "RCTRequired"
s.dependency "RCTTypeSafety"
s.dependency "ReactCommon/turbomodule/core"
end
end
s.source_files = "ios/**/*.{h,m,mm,swift}"
s.private_header_files = "ios/**/*.h"

s.dependency "Iterable-iOS-SDK", "6.5.4"

end

# React Native Core dependency
install_modules_dependencies(s)
end
5 changes: 0 additions & 5 deletions example/ios/Podfile
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,6 @@ target 'ReactNativeSdkExample' do
:app_path => "#{Pod::Config.instance.installation_root}/.."
)

target 'ReactNativeSdkExampleTests' do
inherit! :complete
# Pods for testing
end

post_install do |installer|
# https://github.com/facebook/react-native/blob/main/packages/react-native/scripts/react_native_pods.rb#L197-L202
react_native_post_install(
Expand Down
Loading
Loading