Skip to content

Commit

Permalink
fixes particle holders not naturally gcing (ParadiseSS13#25438)
Browse files Browse the repository at this point in the history
  • Loading branch information
GDNgit authored May 9, 2024
1 parent 1553596 commit 10e32fd
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion code/game/objects/effects/effects.dm
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@
///typepath of the last location we're in, if it's different when moved then we need to update vis contents
var/last_attached_location_type
/// The main item we're attached to at the moment, particle holders hold particles for something
var/atom/parent
var/atom/movable/parent
/// The mob that is holding our item
var/mob/holding_parent

Expand All @@ -181,6 +181,7 @@
if(parent)
UnregisterSignal(parent, list(COMSIG_MOVABLE_MOVED, COMSIG_PARENT_QDELETING))
QDEL_NULL(particles)
parent.vis_contents -= src
return ..()

///signal called when parent is moved
Expand All @@ -192,6 +193,7 @@
///signal called when parent is deleted
/obj/effect/abstract/particle_holder/proc/on_qdel(atom/movable/attached, force)
SIGNAL_HANDLER
attached.vis_contents -= src
qdel(src)//our parent is gone and we need to be as well

///logic proc for particle holders, aka where they move.
Expand Down

0 comments on commit 10e32fd

Please sign in to comment.