use a temp file for cache downloads to prevent data loss when cache f…

…ailed (#8)
Ivan-1F · Jun 26, 2024 · 8ebd743 · 8ebd743
1 parent e454473
commit 8ebd743
Showing 1 changed file with 7 additions and 4 deletions.
diff --git a/mcdreforged_plugin_manager/storage/cache.py b/mcdreforged_plugin_manager/storage/cache.py
@@ -45,6 +45,7 @@ def stop(self):
 
 class Cache(PluginStorage):
     CACHE_PATH = os.path.join(psi.get_data_folder(), 'everything.json')
+    TMP_CACHE_PATH = os.path.join(psi.get_data_folder(), 'everything.json.tmp')
 
     @new_thread('MPMCache')
     def cache(self):
@@ -53,13 +54,15 @@ def cache(self):
         psi.logger.info(tr('cache.cache'))
 
         try:
-            # remove cache if exist
-            if os.path.exists(self.CACHE_PATH) and os.path.isfile(self.CACHE_PATH):
-                os.remove(self.CACHE_PATH)
-            download_file(config.source, self.CACHE_PATH)
+            download_file(config.source, self.TMP_CACHE_PATH)
         except Exception as e:
             psi.logger.warning(tr('cache.exception', e))
         else:
+            # remove cache if exist
+            if os.path.exists(self.CACHE_PATH) and os.path.isfile(self.CACHE_PATH):
+                os.remove(self.CACHE_PATH)
+            os.rename(self.TMP_CACHE_PATH, self.CACHE_PATH)
+
             self.__load()
             psi.logger.info(tr('cache.cached', self.plugin_amount - before))