Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Danmaku Offset #41

Closed
wants to merge 1 commit into from
Closed

Added Danmaku Offset #41

wants to merge 1 commit into from

Conversation

Yejia995
Copy link

更改了以下内容:

  • 添加了弹幕偏移选项用于校准弹幕时间
  • 整合danmakuFilterdanmakuParser为一个函数
  • 精简了danmakuInteractionOptssendDanmakuOpts两个函数
  • sourceButtonOpts和弹幕偏移选项加到了danmakuInteractionOpts当中

@Izumiko
Copy link
Owner

Izumiko commented Apr 17, 2024

弹幕偏移这个应该是针对当前集或者当前番剧的吧?放在通用设置里感觉有点不太合适。
同理,弹幕源这个我倾向于换个地方

@Yejia995
Copy link
Author

弹幕偏移这个应该是针对当前集或者当前番剧的吧?放在通用设置里感觉有点不太合适。 同理,弹幕源这个我倾向于换个地方

嗯没问题,主要是番剧要是有字幕和音轨的话,手机UI会有两排按钮。所以才会想删掉一个按钮而不是加一个新的,我暂时先自用一下吧

@Yejia995 Yejia995 closed this Apr 17, 2024
@Yejia995 Yejia995 deleted the patch-1 branch April 17, 2024 10:41
@Izumiko
Copy link
Owner

Izumiko commented Apr 17, 2024

这样的话,可以把所有的功能整合在一个按钮里,类似jellyfin最右边那个设置按钮,然后根据弹出菜单来选择不同功能

@Yejia995
Copy link
Author

弹幕偏移确实是针对当前番剧比较好,可以在window.ede里存储playingInfo然后在每次加载的时候对比之前的番剧名吗?至于弹幕源虽然放到了模态里,但是提交之后应该是不会存储设置的

@Izumiko
Copy link
Owner

Izumiko commented Apr 17, 2024

仿照getEpisodeInfo里的做法,把offset单独存一个kv值可能更好点?

比如,_id是jellyfin给每个季度分配的id,创建一个_offset_key存储当季的偏移量

let _offset_key = '_anime_offset_rel_' + _id;

window.localStorage.setItem(_offset_key, current_offset);

offset = window.localStorage.getItem(_offset_key) || 0;

@Izumiko
Copy link
Owner

Izumiko commented Apr 17, 2024

至于弹幕源,我是指这个功能和设置相关的项放到一起感觉有点拧巴😂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants