Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sympy compat and enhance formula eval #66

Merged
merged 28 commits into from
Jul 15, 2024
Merged

Fix sympy compat and enhance formula eval #66

merged 28 commits into from
Jul 15, 2024

Conversation

J08nY
Copy link
Owner

@J08nY J08nY commented Jul 11, 2024

Fixes #65 and improves performance of formula evaluation and Mod's siginificantly.

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

Attention: Patch coverage is 82.74510% with 44 lines in your changes missing coverage. Please review.

Project coverage is 87.21%. Comparing base (204f3ed) to head (b61e1f7).

Files Patch % Lines
pyecsca/ec/mod.py 82.98% 27 Missing and 5 partials ⚠️
pyecsca/ec/formula/base.py 85.19% 4 Missing and 4 partials ⚠️
pyecsca/ec/curve.py 50.00% 0 Missing and 2 partials ⚠️
pyecsca/misc/cfg.py 0.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #66      +/-   ##
==========================================
- Coverage   87.51%   87.21%   -0.30%     
==========================================
  Files          86       86              
  Lines        7549     7707     +158     
  Branches     1422     1444      +22     
==========================================
+ Hits         6606     6721     +115     
- Misses        660      697      +37     
- Partials      283      289       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@J08nY J08nY mentioned this pull request Jul 12, 2024
@J08nY J08nY changed the title Fix/sympy 1.13 Fix sympy compat and enhance formula eval Jul 15, 2024
@J08nY J08nY merged commit 1f8e220 into master Jul 15, 2024
29 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sympy 1.13 broke divpoly tests
1 participant