This repository has been archived by the owner on Apr 12, 2023. It is now read-only.
Connection to PROD Db utilizing ENV variable #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. Implemented the value to be parsed into the databases settings. 2. This value is parsed from the operating system environment variable `DATABASE_URL` 3. Added information highlighting the usage in Readme.md Resolves JBossOutreachArchive#16
aashutoshrathi
suggested changes
Nov 26, 2018
There was a problem hiding this comment.
There were errors while connecting DB this way.
@jatinkatyal13 Can you check if this PR works?
|
@aashutoshrathi Yeah there were errors in the production but on my local machine it works like a charm ! Lets try this PR in a staging app and if it works we'll promote it to the production! |
1. Implemented the value to be parsed into the databases settings. 2. This value is parsed from the operating system environment variable `DATABASE_URL` 3. Added information highlighting the usage in Readme.md 4. Placed necessary Environment Variable `DATABASE_URL` in .travis.yml for CI Resolves JBossOutreachArchive#16
|
Hello maintainers, any pending activity for this to be merged ? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented the value to be parsed into the databases settings.
This value is parsed from the operating system environment variable
DATABASE_URLAdded information highlighting the usage in Readme.md
Resolves #16
Notes:
Please let me know for any changes.