-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add namelist and streams filename parameters to mpas_init #10
Conversation
This change is required for JCSDA-internal/mpas-jedi#360. |
Already tested. It works with my case https://github.com/JCSDA-internal/mpas-jedi/pull/495. Thanks @svahl991 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please add this PR to MPAS-Dev#789.
Done. |
This looks good. But should we just use |
Well, I just merged this, although we can still change the variable name. But my thinking in putting |
Fine with me. |
This alters the signature of the mpas_init subroutine in mpas_subdriver.F, adding two optional parameters that allow the caller to pass in filenames for the namelist and streams file. This allows the caller to specify different files to be used, other than namelist.atmosphere and streams.atmosphere in the working directory. This functionality is critical for several use-cases in MPAS-JEDI, including the ConvertState application, which interpolates data between two MPAS meshes of different resolutions.
This alters the signature of the
mpas_init
subroutine inmpas_subdriver.F
, adding two optional parameters that allow the caller to pass in filenames for the namelist and streams file. This allows the caller to specify different files to be used, other thannamelist.atmosphere
andstreams.atmosphere
in the working directory. This functionality is critical for several use-cases in MPAS-JEDI, including theConvertState
application, which interpolates data between two MPAS meshes of different resolutions.