Added missing EXPECTs in test.

JCSDA-internal · Sep 16, 2024 · f4d3697 · f4d3697
1 parent 73d990f
commit f4d3697
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/src/atlas/array/ArrayViewVariant.cc b/src/atlas/array/ArrayViewVariant.cc
@@ -8,6 +8,7 @@
 #include "atlas/array/ArrayViewVariant.h"
 
 #include <string>
+#include <type_traits>
 
 #include "atlas/runtime/Exception.h"
 

diff --git a/src/tests/array/test_array_view_variant.cc b/src/tests/array/test_array_view_variant.cc
@@ -128,13 +128,15 @@ CASE("test std::visit") {
 
     const auto visitor = [&](auto&& view) {
       if constexpr (Rank<decltype(view)>() == 1) {
-        testRank1(view);
         rank1Tested = true;
+        return testRank1(view);
       }
       if constexpr (Rank<decltype(view)>() == 2) {
-        testRank2(view);
         rank2Tested = true;
+        return testRank2(view);
       }
+      // Test should not reach here.
+      EXPECT(false);
     };
 
     std::visit(visitor, var1);
@@ -158,7 +160,8 @@ CASE("test std::visit") {
           rank2Tested = true;
         },
         [](auto&& view) -> std::enable_if_t<(Rank<decltype(view)>() > 2)> {
-          // do nothing.
+          // Test should not reach here.
+          EXPECT(false);
         }};
 
     std::visit(visitor, var1);

diff --git a/src/tests/util/CMakeLists.txt b/src/tests/util/CMakeLists.txt
@@ -94,4 +94,3 @@ ecbuild_add_test( TARGET atlas_test_unitsphere
   ENVIRONMENT ${ATLAS_TEST_ENVIRONMENT}
 )
 
-