Skip to content

Commit

Permalink
Add a clause in the cleanup to fix directory permissions (#1273)
Browse files Browse the repository at this point in the history
A change in #1270 uncovered a behavior where go mod derived package install modules cannot be removed from our scratch directory due to undesirable folder permissions. This has been observed before and golang maintainers marked the behavior as WAI suggesting that people maintain these directory trees with go-language tools. In our case this is not highly feasible due to spack's intervention in the project structure meaning we must find a workaround.

The workaround here uses find to update directory permissions to ensure that write/execute is set on all directories in the tree. This has been tested locally but due to environment carryover we cannot ensure it has the desired effect for go packages in our CI system until it is submitted. (Ie; testing would require re-running an affected workflow and all other pull requests would still be subject to the issue and would break).
  • Loading branch information
eap authored Aug 23, 2024
1 parent 489665d commit a9c3d63
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions .github/workflows/macos-ci-aarch64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
run: |
pwd
ls -lart
find ./* -type d -exec chmod u+xw {} \;
rm -fr *
- name: checkout
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ubuntu-ci-x86_64-gnu.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
run: |
pwd
ls -lart
find ./* -type d -exec chmod u+xw {} \;
rm -fr *
- name: checkout
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ubuntu-ci-x86_64-intel.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
run: |
pwd
ls -lart
find ./* -type d -exec chmod u+xw {} \;
rm -fr *
- name: checkout
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ubuntu-ci-x86_64-oneapi.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ jobs:
run: |
pwd
ls -lart
find ./* -type d -exec chmod u+xw {} \;
rm -fr *
- name: checkout
Expand Down

0 comments on commit a9c3d63

Please sign in to comment.