-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from zlib to zlib-ng #1016
Conversation
Looks like at least the MacOS CI is still building regular zlib... https://github.com/JCSDA/spack-stack/actions/runs/8115572790/job/22183711124 Edit: Also Ubuntu: https://github.com/JCSDA/spack-stack/actions/runs/8115572792/job/22183711121?pr=1016 |
28ee42c
to
254a93b
Compare
I actually thought we were already doing this. In our testing ng-zlib was about 10% faster than zlib. |
@AlexanderRichert-NOAA I finally started testing this PR together with #972 and JCSDA/spack#400 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested this with a few JEDI-Skylab experiments and it works just fine. Thanks!
Summary
This PR moves from zlib to zlib-ng. Time to get with the times.
For now I'm not touching any of the templates.
Testing
Tested on Hera & personal machine. Successfully concretizes without zlib, and on Hera, the UFS WM deps build and RTs run successfully.
Applications affected
All
Systems affected
All
Dependencies
JCSDA/spack#409
Issue(s) addressed
#902
Checklist