-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update project_charter/documentation, update util/check_package_config.py, remove upp from unified-dev #1022
Merged
climbfuji
merged 11 commits into
JCSDA:develop
from
climbfuji:feature/update_check_package_config_and_remove_upp
Mar 11, 2024
Merged
Update project_charter/documentation, update util/check_package_config.py, remove upp from unified-dev #1022
climbfuji
merged 11 commits into
JCSDA:develop
from
climbfuji:feature/update_check_package_config_and_remove_upp
Mar 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_config.py: import yaml from spack _vendored, catch non-existent variants
…ainers and install responsibilities
climbfuji
added
INFRA
JEDI Infrastructure
NOAA-EMC
OAR-EPIC
NOAA Oceanic and Atmospheric Research and Earth Prediction Innovation Center
labels
Mar 8, 2024
climbfuji
force-pushed
the
feature/update_check_package_config_and_remove_upp
branch
2 times, most recently
from
March 8, 2024 04:09
187d2f4
to
ef5bbfa
Compare
climbfuji
force-pushed
the
feature/update_check_package_config_and_remove_upp
branch
from
March 8, 2024 04:10
ef5bbfa
to
abb3a4e
Compare
…eature/update_check_package_config_and_remove_upp
climbfuji
force-pushed
the
feature/update_check_package_config_and_remove_upp
branch
7 times, most recently
from
March 8, 2024 14:41
fd7472e
to
6d3c791
Compare
climbfuji
force-pushed
the
feature/update_check_package_config_and_remove_upp
branch
from
March 8, 2024 14:46
6d3c791
to
2ae50c5
Compare
climbfuji
commented
Mar 8, 2024
climbfuji
requested review from
AlexanderRichert-NOAA,
RatkoVasic-NOAA,
edwardhartnett and
ulmononian
March 8, 2024 14:49
RatkoVasic-NOAA
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
ulmononian
approved these changes
Mar 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
all good!
…eature/update_check_package_config_and_remove_upp
edwardhartnett
approved these changes
Mar 11, 2024
climbfuji
deleted the
feature/update_check_package_config_and_remove_upp
branch
March 11, 2024 17:29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
README.md
,project_charter.md
and documentation with new maintainers and install responsibilitiesupp
fromufs-srw-app-env
virtual package and clean upunified-dev
templateutil/check_package_config.py
: import yaml from spack _vendored, catch non-existent variants, test on macOSutil/ldd_check.py
and documentation - this tool only works on LinuxTesting
Applications affected
UFS SRW App - check if standalone
upp
is really not requiredSystems affected
None
Dependencies
None
Issue(s) addressed
Resolves #825
Resolves #898
Checklist
All dependency PRs/issues have been resolved and this PR can be merged.