Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin numpy to 1.24 on Acorn #1284

Closed

Conversation

DavidHuber-NOAA
Copy link
Collaborator

@DavidHuber-NOAA DavidHuber-NOAA commented Sep 4, 2024

Summary

This is a follow-up to #1283 where numpy was pinned to 1.23 on all platforms. Acorn needs numpy to be pinned at 1.24.4.

Testing

Will test on Acorn once dogwood is made available to developers.

Applications affected

Likely all of them.

Systems affected

Acorn

Issue(s) addressed

References #1276

Checklist

  • This PR addresses one issue/problem/enhancement, or has a very good reason for not doing so.
  • These changes have been tested on the affected systems and applications.
  • All dependency PRs/issues have been resolved and this PR can be merged.

@DavidHuber-NOAA
Copy link
Collaborator Author

I was unable to concretize this on Acorn. I get the error that the version requirement for eccodes is invalid:

$ git checkout origin/fix/acorn_numpy && git submodule update --init && spack stack create env --site acorn --template unified-dev --name fix-acorn --compiler intel
...
==> Created environment /lfs/h1/emc/eib/noscrub/David.Huber/SPACK/acorn_update/envs/fix-acorn
$ cd envs/fix-acorn
$ spack env activate .
$ spack concretize
==> Fetching https://mirror.spack.io/bootstrap/github-actions/v0.5/build_cache/linux-centos7-x86_64-gcc-10.2.1-clingo-bootstrap-spack-t4yf34cuvquqp5xd66zybmcfyhwbdlsf.spec.json
==> Fetching https://mirror.spack.io/bootstrap/github-actions/v0.5/build_cache/linux-centos7-x86_64/gcc-10.2.1/clingo-bootstrap-spack/linux-centos7-x86_64-gcc-10.2.1-clingo-bootstrap-spack-t4yf34cuvquqp5xd66zybmcfyhwbdlsf.spack
==> Installing "clingo-bootstrap@=spack%gcc@=10.2.1~docs+ipo+optimized+python+static_libstdcpp build_system=cmake build_type=Release generator=make patches=bebb819,ec99431 arch=linux-centos7-x86_64" from a buildcache
==> Error: Version requirement 2.27.0 on eccodes for eccodes cannot match any known version from package.py or externals

Do I need to load some modules to get this to work?

@climbfuji
Copy link
Collaborator

[ne-aocc-4.0.0] [heinzell@nautilus08 spack-stack-1.8.0-rc1]$ spack info eccodes
CMakePackage:   eccodes

Description:
    ecCodes is a package developed by ECMWF for processing meteorological
    data in GRIB (1/2), BUFR (3/4) and GTS header formats.

Homepage: https://software.ecmwf.int/wiki/display/ECC/ecCodes+Home

Preferred version:
    2.34.0     https://confluence.ecmwf.int/download/attachments/45757960/eccodes-2.34.0-Source.tar.gz?api=v2

Safe versions:
    develop    [git] https://github.com/ecmwf/eccodes.git on branch develop
    2.34.0     https://confluence.ecmwf.int/download/attachments/45757960/eccodes-2.34.0-Source.tar.gz?api=v2
    2.33.0     https://confluence.ecmwf.int/download/attachments/45757960/eccodes-2.33.0-Source.tar.gz?api=v2
    2.32.1     https://confluence.ecmwf.int/download/attachments/45757960/eccodes-2.32.1-Source.tar.gz?api=v2
    2.32.0     https://confluence.ecmwf.int/download/attachments/45757960/eccodes-2.32.0-Source.tar.gz?api=v2
    2.31.0     https://confluence.ecmwf.int/download/attachments/45757960/eccodes-2.31.0-Source.tar.gz?api=v2
    2.25.0     https://confluence.ecmwf.int/download/attachments/45757960/eccodes-2.25.0-Source.tar.gz?api=v2
    2.24.2     https://confluence.ecmwf.int/download/attachments/45757960/eccodes-2.24.2-Source.tar.gz?api=v2
    2.23.0     https://confluence.ecmwf.int/download/attachments/45757960/eccodes-2.23.0-Source.tar.gz?api=v2
    2.22.1     https://confluence.ecmwf.int/download/attachments/45757960/eccodes-2.22.1-Source.tar.gz?api=v2
    2.21.0     https://confluence.ecmwf.int/download/attachments/45757960/eccodes-2.21.0-Source.tar.gz?api=v2
    2.20.0     https://confluence.ecmwf.int/download/attachments/45757960/eccodes-2.20.0-Source.tar.gz?api=v2
    2.19.1     https://confluence.ecmwf.int/download/attachments/45757960/eccodes-2.19.1-Source.tar.gz?api=v2
    2.18.0     https://confluence.ecmwf.int/download/attachments/45757960/eccodes-2.18.0-Source.tar.gz?api=v2
    2.13.0     https://confluence.ecmwf.int/download/attachments/45757960/eccodes-2.13.0-Source.tar.gz?api=v2
    2.5.0      https://confluence.ecmwf.int/download/attachments/45757960/eccodes-2.5.0-Source.tar.gz?api=v2
    2.2.0      https://confluence.ecmwf.int/download/attachments/45757960/eccodes-2.2.0-Source.tar.gz?api=v2

2.27 isn't listed. Looks like

needs updating.

@DavidHuber-NOAA
Copy link
Collaborator Author

I updated the eccodes version to 2.31 and concretized. I am installing now.

@DavidHuber-NOAA
Copy link
Collaborator Author

DavidHuber-NOAA commented Sep 4, 2024

Unfortunately, 2.31 does not compile on acorn. We'll probably have to revert to 2.25.

@DavidHuber-NOAA
Copy link
Collaborator Author

[email protected] built successfully.

@AlexanderRichert-NOAA
Copy link
Collaborator

I'll be submitting a PR with Acorn updates shortly which will include the numpy version setting.

@DavidHuber-NOAA
Copy link
Collaborator Author

Closing in favor of #1285.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants