Update ESMF (partially) and MAPL from spack/develop #313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
climbfuji
changed the title
…into feature/update_esmf_mapl
Merged
6 tasks
climbfuji
changed the title
climbfuji
requested review from
mathomp4,
AlexanderRichert-NOAA,
jedwards4b and
ulmononian
jedwards4b
approved these changes
Aug 29, 2023
ulmononian
approved these changes
Aug 29, 2023
|
@mathomp4 Ok to merge this? We can bring in your pflogger update as a follow-up. |
mathomp4
approved these changes
Aug 29, 2023
I approved. Hopefully we can figure out the pflogger thing soon...it's very useful for those using MAPL! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For ESMF, manually copy the new version 8.5.0 to our fork and mark 8.3.0b09 as deprecated. There is no clean way to cherry-pick these changes, because our fork has many updates (improvements) that we need to send back to spack/develop first. (I am volunteering to do that after this PR is merged.)
For MAPL, cherry-pick the latest commit (entire file -
git checkout spack/develop -- var/spack/repos/builtin/packages/mapl/package.py) so that the file is identical to what's in spack/develop.Corresponding spack-stack PR is JCSDA/spack-stack#752
Issue(s) addressed
Working towards JCSDA/spack-stack#753
Dependencies
n/a
Impact
Expected impact on downstream repositories: UFS and JEDI applications using ESMF/MAPL
Checklist
I have made corresponding changes to the documentation