JOSM #22750 - Make ImproveWayAccuracyAction extendible #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plugin ImproveWay needs this
this allows child classes to override position
|
@kolesar-andras : Can you please open a ticket on JOSM Trac for this? |
stoecker
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ImproveWay plugin used same code base as ImproveWayAccuracy mode. Half of code was unnecessary duplication with old code. Moreover, both action in core and plugin needed to be maintained. Common code parts have diverged in years.
This MR makes core action to be extendible. ImproveWay plugin was refactored to extend this class. This change eliminates code duplication.