Add support for alternative tagging of the presets.

[Sarabjeet108]

Would it be better if we create two separate List for storing PresetLink objects with alternative="true" and the ones that don't have an alternative tag like presets under the "Edit also" section?

The current implementation depends on the order in which preset_link is defined in the XML file. It does not work if the preset_link with the alternative attribute is defined before the non-alternative ones or between them.

@tsmock

[tsmock]

It would probably be preferable to have two separate lists. We could sort based off of the alternative tag, but then we start getting into changing the order of the alternatives. This is probably undesirable, if the preset author put the preferred alternative first.

[Sarabjeet108]

I added lists to store the PresetLink objects. Is there a need to sort the tags in the list?

[simonpoole]

In a follow up to @tsmock comment: from a functional pov an "alternative preset" is different than a "linked preset". The later offers additional tags that might be added, the former replaces the current tagging with an alternative.

tl;dr the alternative preset links need a separate heading/label that makes the above clear (the "Edit also..." is very confusing here).

[tsmock]

I'm not quite certain what you are trying to say/change here.

[tsmock]

We only use createLabel in one location. These two methods should probably be consolidated.

Suggested change

	initializeLocaleText(tr("Additional tags to edit"));
	return new JLabel(locale_text);
	}
	/**
	* Creates a label to be inserted above the alternative presets
	* @return a label
	*/
	public JLabel createAlternativeLabel() {
	initializeLocaleText(tr("Similar but different tags"));
	if (!alternative) {
	initializeLocaleText(tr("Additional tags to edit"));
	return new JLabel(locale_text);
	}
	initializeLocaleText(tr("Similar but different tags"));

[tsmock]

If you consolidate the createLabel/createAlternativeLabel, this could be done like so:

Suggested change

	if (!alternativeTags.isEmpty()) {
	PresetLink link = new PresetLink();
	itemPanel.add(link.createAlternativeLabel(), GBC.eol().insets(0, 8, 0, 0));
	for (PresetLink links : alternativeTags) {
	links.addToPanel(itemPanel, itemGuiSupport);
	p.hasElements = true;
	}
	}
	if (!editAlsoTags.isEmpty()) {
	PresetLink link = new PresetLink();
	itemPanel.add(link.createLabel(), GBC.eol().insets(0, 8, 0, 0));
	for (PresetLink links : editAlsoTags) {
	links.addToPanel(itemPanel, itemGuiSupport);
	p.hasElements = true;
	}
	for (List<PresetLink> linkList : Arrays.asList(alternativeTags, editAlsoTags)) {
	if (!linkList.isEmpty()) {
	PresetLink link = new PresetLink();
	itemPanel.add(link.createLabel(), GBC.eol().insets(0, 8, 0, 0));
	for (PresetLink links : linkList) {
	links.addToPanel(itemPanel, itemGuiSupport);
	p.hasElements = true;
	}
	}
	}

[Sarabjeet108]

link.isAlternative() is always false, therefore same label is being created for both preset alternative and editalso tags. We may want to create label based on the links of the linkedList

[tsmock]

You might want to add a comment for this (e.g. "Not adding preset links to panel here since we want to order alternative tags and tags that users may want to use in addition").