Update to upstream-gate #25
Conversation
There was a problem hiding this comment.
Good job. There are few things which you have to fix.
In particular, fix the tabs in the function GateTrajectoryNavigator::FindAnnihilationGammasTrackID() (file digits_hits/src/GateTrajectoryNavigator.cc) and make code more clear - at this moment it is hard to say what it does and does it work correctly.
| strcpy(theCRData.theComptonVolumeName1, G4String("NULL").c_str()); | ||
| strcpy(theCRData.theComptonVolumeName2, G4String("NULL").c_str()); | ||
| strcpy(theCRData.theRayleighVolumeName1, G4String("NULL").c_str()); | ||
| strcpy(theCRData.theRayleighVolumeName2, G4String("NULL").c_str()); | ||
| m_ionDecayPos = G4ThreeVector(0., 0., 0.); | ||
| m_positronGenerationPos = G4ThreeVector(0., 0., 0.); | ||
| m_positronAnnihilPos = G4ThreeVector(0., 0., 0.); |
There was a problem hiding this comment.
In my opinion m_ionDecayPos, m_positronGenerationPos and m_positronAnnihilPos should be present in the method GateToRoot::RecordBeginOfEvent. They should be reseted for each event.
In my opinion, you accidentally deleted these lines - this won't show up as a compile-time error, but it's a runtime error.
Please compare your code with https://github.com/OpenGATE/Gate/blob/develop/source/digits_hits/src/GateToRoot.cc#L607
| << " --- current one read from last Tracks Root File " << fTracksFN << " is " << EventID | ||
| << Gateendl; | ||
| if (EventID != lastEventID) | ||
| { // if ( m_verboseLevel > 3 ) { |
There was a problem hiding this comment.
you can delete commented code // if ( m_verboseLevel > 3 ) { and //}
…fEvent method makes RecordEndOfEvent method easier to understand
…ent make code more readable
…fEvent method makes this method easier to understand
… makes this method easier to understand
…ake code more readable
…otonIDVec in case of finding 2 photons
No description provided.