-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker Scaffolding #3
Conversation
…ded some missing dependencies that appeared to be required.
…rs where other services will be implemented. Updates README.
✅ Deploy Preview for molevolvr ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Something that might be useful, since we may have many people on the team running this locally, is to open the webapp automatically when running the stack. Normally this is easy by just running One of the benefits of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks good to me. Tested it out locally, and frontend, plumbr hello world, and swagger docs seem to work as expected.
Pending my other comments, feel free to merge.
Co-authored-by: Vincent Rubinetti <[email protected]>
Co-authored-by: Vincent Rubinetti <[email protected]>
Co-authored-by: Vincent Rubinetti <[email protected]>
…en DO_OPEN_BROWSER=0.
…ments to explain why.
So, I've added a very work-in-progress production configuration that actually uses the I believe I've addressed your other points, @vincerubinetti, but please let me know if I missed something. Also, thank you very much for the thorough review and commentary! |
This PR adds the following:
docker-compose.*.yml
files for various environmentsrun_stack.sh
, which facilitates building images and running the Docker Compose stackbackend
folder, Dockerfile, other supporting bits; includes a simple "Hello, world!" plumber API servercluster
: SLURM Dockerfiles, configservices/postgres
: configuration for the PostgreSQL instanceREADME.md
describing the above.env
fileI'll be submitting a PR for the backend shortly that implements a more fleshed-out API and other supporting bits for the backend, but I didn't want to complicate this PR with it. I anticipate that we can get this PR approved first, then I'll submit the second backend PR that contains a more concrete skeleton of the API, and get that merged. We can then start integrating the frontend into the backend and iterate on the backend API and schema as needed.
At the moment, this builds and runs the frontend at http://localhost:5713, and the plumber API at http://localhost:9050. You should be able to access both after copying your
.env.TEMPLATE
as.env
and invoking./run_stack.sh
.