Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

QOL - update yoga version #195

Merged
merged 1 commit into from
Jul 19, 2024
Merged

QOL - update yoga version #195

merged 1 commit into from
Jul 19, 2024

Conversation

fforres
Copy link
Member

@fforres fforres commented Jul 19, 2024

Looking at the changelogs, https://the-guild.dev/graphql/yoga-server/changelog#531 the next minor version of what we are using has this change:

#3197 f775b341 Thanks @n1ru4l! - Experimental support for aborting GraphQL execution when the HTTP request is canceled.
In such environments like CloudFlare Workers, the request object in the context always has the initial request object, so it was impossible to access the actual Request object from the execution context. Now Yoga ensures that the request in the context is the same with the actual Request.

This should help improve issues with local development we are seeing across the board.

Tangentially...this is a very interesting read on how CF handles sharing context in between rqeuests and the diffrences of local-dev v/s prod

Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 80.18% 9135 / 11392
🔵 Statements 80.18% 9135 / 11392
🔵 Functions 78.18% 276 / 353
🔵 Branches 83.37% 712 / 854
File CoverageNo changed files found.
Generated in workflow #783

@fforres fforres merged commit fc1fb89 into main Jul 19, 2024
6 checks passed
@fforres fforres deleted the fforres/yoga-update branch July 19, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant