Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calendar parsing for new MyUW Vue schedule cards #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timtim17
Copy link

@timtim17 timtim17 commented Apr 7, 2022

MyUW recently went through a restructure, where many components including the schedule card became Vue components. This breaks this extension, as it can no longer read the calendar data, or place the icon to begin with.

This PR allows for the extension to be invoked by adding the icon back to the card, as well as fixes the ability to parse the schedule data.

Instead of hijacking the card's render handler, a timer is used to periodically check if the card has rendered before adding the icon. Perhaps this does not feel like the best solution.

The structure of the schedule data when pulled from the Vue store seems to be a little different, but it appears to work.

Existing Behavior

screenshot of schedule with no icon and error in console

Icon is not added to the card due to an error.

Proposed Behavior

screencast

@timtim17 timtim17 force-pushed the timtim17/patch-myuw-vue branch from 3d61b0f to a44c423 Compare April 7, 2022 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant