-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interactive plotter #81
Merged
Merged
Changes from 51 commits
Commits
Show all changes
60 commits
Select commit
Hold shift + click to select a range
436e118
First draft of InteractiveCohpPlotter
kaueltzen bf77096
Fixed layout_dict import, color scheme
kaueltzen fa554ab
fixed relevant bonds iter. error, added x axis rangeslider
kaueltzen 5b4eedd
Merge branch 'interactive_plotter' of github.com:ahtakkatha/LobsterPy…
kaueltzen 6946097
Fixed merging error
kaueltzen 7eaf71b
Added plot_interactive_cohps() to description class (summed COHPs)
kaueltzen 9df8c4c
Fixed plot_interactive_cohps() to plot COHPs in same plot
kaueltzen 9bec1b3
Made rangeslider optional, fixed legend display, added different inte…
kaueltzen ae21a80
Merge branch 'JaGeo:main' into interactive_plotter
kaueltzen 79eb6b5
Removed integration options that were recently moved to another branc…
kaueltzen e22744b
Merge branch 'main' into interactive_plotter
kaueltzen 376b009
Removed redundant COHPCAR reading (significantly faster), modified pl…
kaueltzen 6d42115
Fixed importation error.
kaueltzen e8ba02e
Merge branch 'JaGeo:main' into interactive_plotter
naik-aakash 52bd8a9
add dropdown to interactive plotter layout, add option to plot direct…
naik-aakash 7ea3f94
Merge branch 'JaGeo:main' into interactive_plotter
naik-aakash cd80e13
Merge branch 'JaGeo:main' into interactive_plotter
naik-aakash 5a7bda3
update plotter
naik-aakash 773ef9b
adapt plot_interactive_cohps of describe method
naik-aakash 2ca4f13
Fix linting issues
naik-aakash 3c7bdb7
add preliminary tests for interactive plotter
naik-aakash c58b9c6
attempt to fix failing 3.9 and 3.10 tests
naik-aakash caf2d01
fix interactive plot test
naik-aakash cc230ff
Fix interactive plotlyfigure object data checking
naik-aakash 4343ac4
remove unused import
naik-aakash 807c44c
add test for interactive plotter from describe method
naik-aakash d33c63f
update test_plotting.py
naik-aakash 3c3bd40
fix pylint error for describe.py
naik-aakash 6fa68ef
update test_plotting.py
naik-aakash c2bb10a
make interactive plot labels consistent to analyze output, add test f…
naik-aakash 84df95a
clean up interactive plotter code,fix handle duplicate label with lab…
naik-aakash af242ed
more cleanup: remove redundant dropdown from interactive plotter, upd…
naik-aakash 447f287
remove redundant _update_cohps_data method, simplify code logic
naik-aakash 7de1cf3
Fix visibility inconsitency for "All" key in dropdown menu
naik-aakash 7df457d
Merge branch 'JaGeo:main' into interactive_plotter
naik-aakash afd32e3
update bond labels in label resolved, add more tests to increase cove…
naik-aakash 0594cdf
Merge branch 'interactive_plotter' of github.com:kaueltzen/LobsterPy …
naik-aakash 8f6918e
Merge branch 'JaGeo:main' into interactive_plotter
naik-aakash 71240bc
Merge branch 'main' of github.com:JaGeo/LobsterPy into interactive_pl…
JaGeo aa80966
Change set to seq
JaGeo b43b74c
fix bug and reformat
JaGeo 655e638
Fix hide
JaGeo a667a72
Fix cation anion
JaGeo 5165ba3
Fix documentation
JaGeo a6b54f1
Fix cation anion
JaGeo bccacde
code reformatting based on review
naik-aakash 99e2671
remove unused import
naik-aakash 32a5dfd
fix doc string
naik-aakash 20cd3bd
fix exception text
naik-aakash 36f0de9
add docstring to private _insert_number_of_bonds_in_label
naik-aakash 545e6c5
fix doc-string linting error, improve code readability
naik-aakash 2bac25b
imporve code formatting
naik-aakash 0896844
add color arg to get_plot, refactor add_all_relevant_cohps method, ad…
naik-aakash abcb119
run black
naik-aakash 1eed7f8
removed __future__ import
naik-aakash 250d236
attempt to fix python3.8 linitng error
naik-aakash d012563
remove unnecessary variable assignment
naik-aakash f5f6a8d
update tests for custom colors, update tutorial for interactiveplotte…
naik-aakash 79d5749
update tutorial files
naik-aakash 3924374
update doc generation conf.py file to exclude plotter test
naik-aakash File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
1 change: 1 addition & 0 deletions
1
lobsterpy/TestData/interactive_plotter_ref/analyse_NaCl_label.json
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
Binary file not shown.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't
show=True
be a more natural way of expressing this? (I appreciate this also applies to plot_cohps...)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right. It's like this in the normal plotter classes as well as I wanted to quickly provide a fix for one project and did not fully think it through ... 😅.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will replace it with "hide" as we would otherwise also need to adapt the atomate2 workflows and schema.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't understand, how would using "show" break a workflow but using "hide" not break it? The default behaviour can be the same either way. (i.e.
show=True
is equivalent toskip_show=False
.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, you are correct. We have to update it in any case as I changed the argument name...🙈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@naik-aakash , maybe we can fix this here and the snake case issue of "whichbonds" as well... As we will break the atomate2 workflow in any case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It might make sense to invert the logic at the CLI with something like
add_argument('--hide', action='store_false', dest='show', ...)