Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented "Current selection" group option #11455

Closed
wants to merge 3 commits into from

Conversation

m-peeler
Copy link
Contributor

@m-peeler m-peeler commented Jul 5, 2024

Added new option to the "Group Options" in the GroupDialog to allow the creation of a group that contains the currently selected entries. If there are no entries selected, this option is disabled. If there is more than one entry selected, this option is selected by default.

image

Closes #11449.

Mandatory checks

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

Added new option to the "Group Options" in the GroupDialog to allow the creation of a group that contains the currently selected entries. If there are no entries selected, this option is disabled. If there is more than one entry selected, this option is selected by default.
m-peeler added a commit to m-peeler/user-documentation that referenced this pull request Jul 5, 2024
Added information on *Group by Current Selection*, featured added by JabRef/jabref#11455
Fixes failed unit test (keyValueShouldBeEqualForEnglishPropertiesMessages) and style test ( '(' is preceded with whitespace.)
@koppor koppor added the groups label Jul 6, 2024
@koppor
Copy link
Member

koppor commented Jul 6, 2024

Added new option to the "Group Options" in the GroupDialog to allow the creation of a group that contains the currently selected entries. If there are no entries selected, this option is disabled. If there is more than one entry selected, this option is selected by default.

I think, the group dialog for adding and editing groups should be the same. The current proposal also shows "Current selection" when editing a group:

image

See https://docs.jabref.org/finding-sorting-and-cleaning-entries/groups#types-of-groups for the semantics of the different radio buttons.

Maybe, we do not overoptimize too much and just add the selected entries to a group if "Explicit Selection" was chosen.

I think the seldom case of unassignment can be easily done by a user.

(I thought, there was an issue regarding unassignment via drag and drop at https://github.com/JabRef/jabref/issues?q=sort%3Aupdated-desc+is%3Aissue+is%3Aopen+label%3Agroups, but I did not find it)

This solution contradicts the intention of groups.

image

Closes #11449.

Mandatory checks

* [x]  Change in `CHANGELOG.md` described in a way that is understandable for the average user (if applicable)

* [ ]  Tests created for changes (if applicable)

* [x]  Manually tested changed features in running JabRef (always required)

* [x]  Screenshots added in PR description (for UI changes)

* [ ]  [Checked developer's documentation](https://devdocs.jabref.org/): Is the information available and up to date? If not, I outlined it in this pull request.

* [x]  [Checked documentation](https://docs.jabref.org/): Is the information available and up to date? If not, I created an issue at [JabRef/user-documentation/issues](https://github.com/JabRef/user-documentation/issues?q=sort%3Aupdated-desc+is%3Aissue+is%3Aopen) or, even better, I submitted a pull request to the documentation repository.

CHANGELOG.md Outdated Show resolved Hide resolved
@koppor koppor marked this pull request as draft July 9, 2024 07:12
@koppor
Copy link
Member

koppor commented Jul 9, 2024

@m-peeler Please merge upstream/main, reposition CHANGELOG.md entry, and adress th review commends 😅

Co-authored-by: Oliver Kopp <[email protected]>
@koppor
Copy link
Member

koppor commented Jul 9, 2024

@m-peeler Please see the failing test. Longer story: We made a release inbetween. Thus, your change will go into a next release. Therefore the test "CHANGELOG.md - only unreleased touched" was red.

@m-peeler
Copy link
Contributor Author

m-peeler commented Jul 9, 2024 via email

@koppor
Copy link
Member

koppor commented Aug 4, 2024

Yes! Was writing a comment but had to run off somewhere. I’ve just made a second pull request with this feature and a create-on-right-click one

Then, I will close this PR - and we will concentrate on #11476.

@koppor koppor closed this Aug 4, 2024
ThiloteE added a commit to JabRef/user-documentation that referenced this pull request Sep 8, 2024
* Updated Groups documentation to reflect #11455

Added information on *Group by Current Selection*, feature added by JabRef/jabref#11455

* Fix Lint and add to types of groups

---------

Co-authored-by: ThiloteE <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

After creation of a group, the group should be focused
2 participants