Add options to auto generate embeddings and summaries #11833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Siedlerchr
reviewed
Sep 26, 2024
| @@ -28,7 +35,8 @@ | |||
| * Use this class in the logic and UI. | |||
| */ | |||
| public class IngestionService { | |||
| private final Map<LinkedFile, ProcessingInfo<LinkedFile, Void>> ingestionStatusMap = new HashMap<>(); | |||
| // We use a {@link TreeMap} here for the same reasons we use it in {@link ChatHistoryService}. | |||
| private final TreeMap<LinkedFile, ProcessingInfo<LinkedFile, Void>> ingestionStatusMap = new TreeMap<>((o1, o2) -> o1 == o2 ? 0 : o1.getLink().compareTo(o2.getLink())); | |||
There was a problem hiding this comment.
You can use the more easier way with Compartor.comparing( ... )
https://www.baeldung.com/java-8-comparator-comparing
4 tasks
koppor
requested changes
Sep 26, 2024
Comment on lines
68
to
105
| private void configureDatabaseListeners(StateManager stateManager) { | ||
| stateManager.getOpenDatabases().addListener((ListChangeListener<BibDatabaseContext>) change -> { | ||
| while (change.next()) { | ||
| if (change.wasAdded()) { | ||
| change.getAddedSubList().forEach(this::configureDatabaseListeners); | ||
| } | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| private void configureDatabaseListeners(BibDatabaseContext bibDatabaseContext) { | ||
| // GC was eating the listeners, so we have to fall back to the event bus. | ||
| bibDatabaseContext.getDatabase().registerListener(new EntriesChangedListener(bibDatabaseContext)); | ||
| } | ||
|
|
||
| private class EntriesChangedListener { | ||
| private final BibDatabaseContext bibDatabaseContext; | ||
|
|
||
| public EntriesChangedListener(BibDatabaseContext bibDatabaseContext) { | ||
| this.bibDatabaseContext = bibDatabaseContext; | ||
| } | ||
|
|
||
| @Subscribe | ||
| public void listen(EntriesAddedEvent e) { | ||
| e.getBibEntries().forEach(entry -> { | ||
| if (aiPreferences.getAutoGenerateSummaries()) { | ||
| summarize(entry, bibDatabaseContext); | ||
| } | ||
| }); | ||
| } | ||
|
|
||
| @Subscribe | ||
| public void listen(FieldChangedEvent e) { | ||
| if (e.getField() == StandardField.FILE && aiPreferences.getAutoGenerateSummaries()) { | ||
| summarize(e.getBibEntry(), bibDatabaseContext); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
Move this code to UI.
The logic should not depend on the UI (see architecture tests).
Reason: AI should also be usable via CLI.
There was a problem hiding this comment.
StateManager belongs to UI?
There was a problem hiding this comment.
Yes. See the package of the StateManger.
You can also see it, because it holds the list of opened BibTeX files
# Conflicts: # src/main/java/org/jabref/gui/preferences/ai/AiTab.fxml
|
Updated |
koppor
requested changes
Oct 4, 2024
| @@ -58,12 +56,13 @@ public class ChatHistoryService implements AutoCloseable { | |||
|
|
|||
| private static final String CHAT_HISTORY_FILE_NAME = "chat-histories.mv"; | |||
|
|
|||
| private final StateManager stateManager = Injector.instantiateModelOrService(StateManager.class); | |||
There was a problem hiding this comment.
I think, you can move the class to logic. No gui dependency as far as I can see.
Also the JavaDoc can be updated --> no more use of StateManager.
| @@ -28,7 +35,8 @@ | |||
| * Use this class in the logic and UI. | |||
| */ | |||
| public class IngestionService { | |||
| private final Map<LinkedFile, ProcessingInfo<LinkedFile, Void>> ingestionStatusMap = new HashMap<>(); | |||
| // We use a {@link TreeMap} here for the same reasons we use it in {@link ChatHistoryService}. | |||
| private final TreeMap<LinkedFile, ProcessingInfo<LinkedFile, Void>> ingestionStatusMap = new TreeMap<>((o1, o2) -> o1 == o2 ? 0 : o1.getLink().compareTo(o2.getLink())); | |||
|
Updated |
koppor
approved these changes
Oct 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially closes the issue https://github.com/JabRef/jabref-issue-melting-pot/issues/546.
NOTE: Please, merge the #11835, before this, to reduce merge conflicts.
New options:
I think this space after "Enable AI" is because of the help button.
I'll address the help buttons in other PR.
Mandatory checks
~- [ ] Change in
CHANGELOG.mddescribed in a way that is understandable for the average user (if applicable)- [ ] Tests created for changes (if applicable)