Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfollow google's recommended app architecture. #224

Merged
merged 7 commits into from
Nov 12, 2024
Merged

Unfollow google's recommended app architecture. #224

merged 7 commits into from
Nov 12, 2024

Conversation

JackEblan
Copy link
Owner

@JackEblan JackEblan commented Nov 11, 2024

Thanks for submitting a pull request. Please include the following information.

What I have done and why

I no longer follow google's recommended app architecture. It solved my previous problem. I realized now how beautiful applying clean architecture. Now, in my domain module, I can actually see the purpose of the app.

Fixes #222

How I'm testing it

Choose at least one:

  • Unit tests
  • UI tests
  • Screenshot tests
  • N/A (provide justification)

Do tests pass?

  • Run local tests on DemoDebug variant: ./gradlew testDemoDebug
  • Check formatting: ./gradlew --init-script gradle/init.gradle.kts spotlessApply

…y previous problem. I realized now how beautiful applying clean architecture. Now, in my domain module, I can actually see the purpose of the app.
Copy link

Combined test coverage report

Overall Project 73.5% -0.4% 🍏
Files changed 76.43% 🍏

Module Coverage
app-settings 83.91% -0.34% 🍏
datastore 77.45% 🍏
settings 77.29% 🍏
domain 72.11% -4.29%
database 71.52% 🍏
apps 60.44% 🍏
service 36.63% -5.89% 🍏
app 30.09% 🍏
Files
Module File Coverage
app-settings TemplateDialogUiState.kt 100% 🍏
AppSettingsUiState.kt 100% 🍏
AppSettingDialogState.kt 100% 🍏
ShortcutDialogState.kt 96.9% 🍏
AppSettingDialog.kt 91.04% 🍏
ShortcutDialog.kt 86.88% 🍏
AppSettingsScreen.kt 81.8% -0.28% 🍏
TemplateDialogState.kt 81.2% 🍏
CommandDialog.kt 79.91% -3.58% 🍏
TemplateDialog.kt 79.68% 🍏
AppSettingsViewModel.kt 71.91% -0.2% 🍏
AppSettingsEvent.kt 56.41% 🍏
datastore GetoPreferencesDataSource.kt 90.29% 🍏
settings SettingsUiState.kt 100% 🍏
DarkDialog.kt 81.5% 🍏
ThemeDialog.kt 81.5% 🍏
SettingsScreen.kt 80.75% 🍏
SettingsViewModel.kt 15.61% 🍏
SettingsEvent.kt 0% 🍏
domain AddAppSettingUseCase.kt 100% 🍏
ForegroundServiceAppSettingsUseCase.kt 100% 🍏
RevertAppSettingsUseCase.kt 98.7% 🍏
ApplyAppSettingsUseCase.kt 98.7% 🍏
RequestPinShortcutUseCase.kt 97.56% 🍏
AutoLaunchUseCase.kt 97.17% 🍏
AppSettingsResult.kt 95.56% 🍏
GetoUsageEvent.kt 95.24% 🍏
RequestPinShortcutResult.kt 94.87% 🍏
ForegroundServiceAppSettingsResult.kt 91.18% 🍏
AddAppSettingResult.kt 90.48% 🍏
DarkThemeConfig.kt 87.8% 🍏
ThemeBrand.kt 85.29% 🍏
GetoShortcutInfoCompat.kt 81.25% 🍏
GetoApplicationInfo.kt 73.33% 🍏
UserData.kt 72.73% 🍏
AppSetting.kt 71.43% 🍏
UpdateUsageStatsForegroundServiceResult.kt 0% -92.59%
AppSettingTemplate.kt 0% 🍏
SecureSetting.kt 0% 🍏
UpdateUsageStatsForegroundServiceUseCase.kt 0% -81.82%
CleanAppSettingsUseCase.kt 0% 🍏
database AppSettingEntity.kt 52.67% 🍏
apps AppsUiState.kt 100% 🍏
AppsViewModel.kt 95.1% 🍏
AppsScreen.kt 62.57% 🍏
service ServiceViewModel.kt 93.51% -6.49% 🍏
ServiceScreen.kt 34.11% -7.69%
ServiceUiState.kt 0% 🍏
app MainActivityUiState.kt 100% 🍏
MainActivityViewModel.kt 100% 🍏
MainActivity.kt 86.43% 🍏

@JackEblan JackEblan merged commit 6dcb38b into master Nov 12, 2024
3 checks passed
@JackEblan JackEblan deleted the domain branch November 12, 2024 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Restructure the modules
1 participant