Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revamped Quick Question Screen #60

Merged
merged 4 commits into from
Sep 21, 2024
Merged

Revamped Quick Question Screen #60

merged 4 commits into from
Sep 21, 2024

Conversation

JackEblan
Copy link
Owner

@JackEblan JackEblan commented Sep 21, 2024

Thanks for submitting a pull request. Please include the following information.

What I have done and why

Optimized code and added more animations

How I'm testing it

Choose at least one:

  • Unit tests
  • UI tests
  • Screenshot tests
  • N/A (provide justification)

Do tests pass?

  • Run local tests on DemoDebug variant: ./gradlew testDemoDebug
  • Check formatting: ./gradlew --init-script gradle/init.gradle.kts spotlessApply

Copy link

Combined test coverage report

Overall Project 34.55% -2.11%
Files changed 0%

Module Coverage
cache 97.9% 🍏
question 5.11% -5.11%
Files
Module File Coverage
cache DefaultInMemoryChoiceDataSource.kt 98.52% 🍏
question QuestionViewModel.kt 94.63% 🍏
QuestionScreen.kt 0% -2.8%
QuickQuestionScreen.kt 0% -19.67%

Copy link

Combined test coverage report

Overall Project 34.79% -1.83%
Files changed 0%

Module Coverage
cache 97.9% 🍏
question 5.19% -4.3%
about 5.01% -1.17%
Files
Module File Coverage
cache DefaultInMemoryChoiceDataSource.kt 98.52% 🍏
question QuestionViewModel.kt 94.63% 🍏
QuestionScreen.kt 0% -3.45%
QuickQuestionScreen.kt 0% -15.28%
about AboutScreen.kt 0% -0.93%
AboutNavigation.kt 0% -9.33%

@JackEblan JackEblan merged commit 071513c into main Sep 21, 2024
3 checks passed
@JackEblan JackEblan deleted the quick branch September 21, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant