Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New algorithm #78

Merged
merged 4 commits into from
Oct 9, 2024
Merged

New algorithm #78

merged 4 commits into from
Oct 9, 2024

Conversation

JackEblan
Copy link
Owner

@JackEblan JackEblan commented Oct 8, 2024

Thanks for submitting a pull request. Please include the following information.

What I have done and why

Simplify submitting choices to each question.

Fixes #77

How I'm testing it

Choose at least one:

  • Unit tests
  • UI tests
  • Screenshot tests
  • N/A (provide justification)

Do tests pass?

  • Run local tests on DemoDebug variant: ./gradlew testDemoDebug
  • Check formatting: ./gradlew --init-script gradle/init.gradle.kts spotlessApply

@JackEblan
Copy link
Owner Author

JackEblan commented Oct 8, 2024

Bugs

  • Multiple choices can show correct choices screen even though all selected choices were unselected. The answered questions size does not reset after choices were unselected.
  • FakeChoiceRepository fails the test on multipleChoices function and I don't know how to fix it.

@JackEblan
Copy link
Owner Author

Kindly add distinct() here

to remove duplicates.

Copy link

github-actions bot commented Oct 9, 2024

Combined test coverage report

Overall Project 33.28% -1.39%
Files changed 27.98%

Module Coverage
cache 91.39% -6.62% 🍏
domain 78.17% -8.12%
question 5.13% -3.18%
Files
Module File Coverage
cache DefaultInMemoryChoiceDataSource.kt 93.24% -6.76% 🍏
domain UpdateChoiceUseCase.kt 0% -50%
question QuestionViewModel.kt 93.41% 🍏
QuestionScreen.kt 0% -4.88%
CorrectChoicesScreen.kt 0% -3.4%
QuickQuestionScreen.kt 0% -4.83%

@JackEblan JackEblan merged commit bf80a4a into main Oct 9, 2024
3 checks passed
@JackEblan JackEblan deleted the new-algorithm branch October 9, 2024 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alternative Algorithm for Submitting answers to every question
1 participant