fix bug #13 #14
Open
fix bug #13 #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| /** | ||
| * fix bug #13 |
There was a problem hiding this comment.
fix #13 这个可以放到最后，在这个之前，用英文说明清晰这里覆写这个的作用。
|
💯 感谢你的RP，可以先将commit message 改为符合 AngularJS's commit message convention ，重新提一个RP，而后的commit都根据这个规范，而后根据我在code上的评论进行修改，保持每个commit尽量的小，有什么问题及时评论，我会尽可能的第一时间给你帮助。 |
|
🎱 修改完以后，你在demo中mock一个你case下的activity。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix bug #13