[#148]: Fix issues with Ubuntu docker build

[JacobDomagala]

Fixes #148

[github-actions]

✅ UBUNTU COMPILE RESULT - SUCCESS! ✅

[github-actions]

✅ WINDOWS COMPILE RESULT - SUCCESS! ✅

[github-actions]

⚡ Static analysis result ⚡

🔴 cppcheck found 27 issues! Click here to see details.

Looper/editor/editor.hpp

Lines 121 to 126 in 085896a

	DrawGrid();
	void
	DrawBoundingBoxes();
	void

!Line: 121 - style: inconclusive: Technically the member function 'looper::Editor::DrawGrid' can be const. [functionConst]
!Line: 714 - note: Technically the member function 'looper::Editor::DrawGrid' can be const.
!Line: 121 - note: Technically the member function 'looper::Editor::DrawGrid' can be const.

Looper/editor/editor.hpp

Lines 215 to 220 in 085896a

	SetMouseOnObject();
	void
	SetupPathfinderNodes();
	void

!Line: 215 - style: inconclusive: Technically the member function 'looper::Editor::SetMouseOnObject' can be const. [functionConst]
!Line: 249 - note: Technically the member function 'looper::Editor::SetMouseOnObject' can be const.
!Line: 215 - note: Technically the member function 'looper::Editor::SetMouseOnObject' can be const.

Looper/engine/game/player.hpp

Lines 61 to 66 in 085896a

	Hit(int32_t /*dmg*/) override
	{
	}
	private:
	void

!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class

Looper/engine/game/player.hpp

Lines 61 to 66 in 085896a

	Hit(int32_t /*dmg*/) override
	{
	}
	private:
	void

!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class

Looper/engine/game/player.hpp

Lines 61 to 66 in 085896a

	Hit(int32_t /*dmg*/) override
	{
	}
	private:
	void

!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class

Looper/engine/game/player.hpp

Lines 61 to 66 in 085896a

	Hit(int32_t /*dmg*/) override
	{
	}
	private:
	void

!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class

Looper/engine/game/player.hpp

Lines 61 to 66 in 085896a

	Hit(int32_t /*dmg*/) override
	{
	}
	private:
	void

!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class

Looper/engine/game/player.hpp

Lines 61 to 66 in 085896a

	Hit(int32_t /*dmg*/) override
	{
	}
	private:
	void

!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class

Looper/engine/game/player.hpp

Lines 61 to 66 in 085896a

	Hit(int32_t /*dmg*/) override
	{
	}
	private:
	void

!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class

Looper/engine/game/player.hpp

Lines 61 to 66 in 085896a

	Hit(int32_t /*dmg*/) override
	{
	}
	private:
	void

!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class

Looper/engine/game/player.hpp

Lines 61 to 66 in 085896a

	Hit(int32_t /*dmg*/) override
	{
	}
	private:
	void

!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class

Looper/engine/game/player.hpp

Lines 61 to 66 in 085896a

	Hit(int32_t /*dmg*/) override
	{
	}
	private:
	void

!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class

Looper/engine/game/player.hpp

Lines 61 to 66 in 085896a

	Hit(int32_t /*dmg*/) override
	{
	}
	private:
	void

!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class

Looper/engine/input/input_manager.cpp

Lines 28 to 33 in 085896a

	InputManager::InternalKeyCallback(GLFWwindow* window, int32_t key, int32_t scancode,
	int32_t action, int32_t mods)
	{
	Logger::Trace("GLFW key {} {} scan code - {}", action, key, scancode);
	keyMap_[key] = action;

!Line: 28 - style: Parameter 'window' can be declared as pointer to const. However it seems that 'InternalKeyCallback' is a callback function, if 'window' is declared with const you might also need to cast function pointer(s). [constParameterCallback]
!Line: 96 - note: You might need to cast the function pointer here
!Line: 28 - note: Parameter 'window' can be declared as pointer to const

Looper/engine/input/input_manager.cpp

Lines 40 to 45 in 085896a

	InputManager::InternalCharCallback(GLFWwindow* window, uint32_t key)
	{
	Logger::Trace("GLFW char {}", key);
	auto event = CharEvent{key};

!Line: 40 - style: Parameter 'window' can be declared as pointer to const. However it seems that 'InternalCharCallback' is a callback function, if 'window' is declared with const you might also need to cast function pointer(s). [constParameterCallback]
!Line: 97 - note: You might need to cast the function pointer here
!Line: 40 - note: Parameter 'window' can be declared as pointer to const

Looper/engine/input/input_manager.cpp

Lines 50 to 55 in 085896a

	InputManager::InternalMouseButtonCallback(GLFWwindow* window, int32_t button, int32_t action,
	int32_t mods)
	{
	Logger::Trace("GLFW mouse button {} {} {}", button, action, mods);
	mouseButtonMap_[button] = action;

!Line: 50 - style: Parameter 'window' can be declared as pointer to const. However it seems that 'InternalMouseButtonCallback' is a callback function, if 'window' is declared with const you might also need to cast function pointer(s). [constParameterCallback]
!Line: 98 - note: You might need to cast the function pointer here
!Line: 50 - note: Parameter 'window' can be declared as pointer to const

Looper/engine/input/input_manager.cpp

Lines 61 to 66 in 085896a

	InputManager::InternalCursorPositionCallback(GLFWwindow* window, double xPos, double yPos)
	{
	Logger::Trace("GLFW cursor pos {} {}", xPos, yPos);
	mousePosition_ = glm::vec2(xPos, yPos);
	auto event = CursorPositionEvent{xPos, yPos};

!Line: 61 - style: Parameter 'window' can be declared as pointer to const. However it seems that 'InternalCursorPositionCallback' is a callback function, if 'window' is declared with const you might also need to cast function pointer(s). [constParameterCallback]
!Line: 99 - note: You might need to cast the function pointer here
!Line: 61 - note: Parameter 'window' can be declared as pointer to const

Looper/engine/input/input_manager.cpp

Lines 72 to 77 in 085896a

	InputManager::InternalMouseScrollCallback(GLFWwindow* window, double xOffset, double yOffset)
	{
	Logger::Trace("GLFW scroll {} {}", xOffset, yOffset);
	auto event = MouseScrollEvent{xOffset, yOffset};

!Line: 72 - style: Parameter 'window' can be declared as pointer to const. However it seems that 'InternalMouseScrollCallback' is a callback function, if 'window' is declared with const you might also need to cast function pointer(s). [constParameterCallback]
!Line: 100 - note: You might need to cast the function pointer here
!Line: 72 - note: Parameter 'window' can be declared as pointer to const

Looper/engine/input/input_manager.cpp

Lines 82 to 87 in 085896a

	InputManager::InternalWindowFocusCallback(GLFWwindow* window, int32_t focused)
	{
	Logger::Trace("GLFW window focus {}", focused);
	auto event = WindowFocusEvent{focused};

!Line: 82 - style: Parameter 'window' can be declared as pointer to const. However it seems that 'InternalWindowFocusCallback' is a callback function, if 'window' is declared with const you might also need to cast function pointer(s). [constParameterCallback]
!Line: 101 - note: You might need to cast the function pointer here
!Line: 82 - note: Parameter 'window' can be declared as pointer to const

Looper/engine/renderer/buffer.cpp

Lines 57 to 62 in 085896a

	Buffer::CopyDataWithStaging(void* data, size_t dataSize) const
	{
	VkBuffer stagingBuffer = {};
	VkDeviceMemory stagingBufferMemory = {};
	Buffer::CreateBuffer(dataSize, VK_BUFFER_USAGE_TRANSFER_SRC_BIT,
	VK_MEMORY_PROPERTY_HOST_VISIBLE_BIT | VK_MEMORY_PROPERTY_HOST_COHERENT_BIT,

!Line: 57 - style: Parameter 'data' can be declared as pointer to const [constParameterPointer]

Looper/engine/renderer/buffer.cpp

Lines 74 to 79 in 085896a

	Buffer::CopyDataToImageWithStaging(VkImage image, void* data, size_t dataSize,
	const std::vector< VkBufferImageCopy >& copyRegions)
	{
	VkBuffer stagingBuffer = {};
	VkDeviceMemory stagingBufferMemory = {};
	Buffer::CreateBuffer(dataSize, VK_BUFFER_USAGE_TRANSFER_SRC_BIT,

!Line: 74 - style: Parameter 'data' can be declared as pointer to const [constParameterPointer]

Looper/engine/game/player.hpp

Lines 61 to 66 in 085896a

	Hit(int32_t /*dmg*/) override
	{
	}
	private:
	void

!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class

Looper/engine/game/player.hpp

Lines 61 to 66 in 085896a

	Hit(int32_t /*dmg*/) override
	{
	}
	private:
	void

!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class

Looper/engine/renderer/texture.hpp

Lines 78 to 83 in 085896a

	TransitionImageLayout(VkImageLayout oldLayout, VkImageLayout newLayout, uint32_t mipLevels);
	void
	CopyBufferToImage(uint8_t* data);
	private:

!Line: 78 - style: inconclusive: Technically the member function 'looper::renderer::Texture::TransitionImageLayout' can be const. [functionConst]
!Line: 434 - note: Technically the member function 'looper::renderer::Texture::TransitionImageLayout' can be const.
!Line: 78 - note: Technically the member function 'looper::renderer::Texture::TransitionImageLayout' can be const.

Looper/engine/renderer/texture.hpp

Lines 81 to 86 in 085896a

	CopyBufferToImage(uint8_t* data);
	private:
	TextureID id_ = {};
	TextureType m_type = {};
	VkImage m_textureImage = {};

!Line: 81 - style: inconclusive: Technically the member function 'looper::renderer::Texture::CopyBufferToImage' can be const. [functionConst]
!Line: 378 - note: Technically the member function 'looper::renderer::Texture::CopyBufferToImage' can be const.
!Line: 81 - note: Technically the member function 'looper::renderer::Texture::CopyBufferToImage' can be const.

Looper/engine/game/player.hpp

Lines 61 to 66 in 085896a

	Hit(int32_t /*dmg*/) override
	{
	}
	private:
	void

!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class

Looper/engine/game/player.hpp

Lines 61 to 66 in 085896a

	Hit(int32_t /*dmg*/) override
	{
	}
	private:
	void

!Line: 61 - style: The function 'Hit' overrides a function in a base class but is identical to the overridden function [uselessOverride]
!Line: 22 - note: Virtual function in base class
!Line: 61 - note: Function in derived class

---

🔴 clang-tidy found 4 issues! Click here to see details.

Looper/engine/renderer/shader.cpp

Lines 14 to 19 in 085896a

	CreateShaderModule(VkDevice device, std::vector< char >&& shaderByteCode)
	{
	VkShaderModuleCreateInfo createInfo = {};
	createInfo.sType = VK_STRUCTURE_TYPE_SHADER_MODULE_CREATE_INFO;
	createInfo.codeSize = shaderByteCode.size();
	// NOLINTNEXTLINE

!Line: 14 - error: function 'CreateShaderModule' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace,-warnings-as-errors]

Looper/engine/core/work_queue.cpp

Lines 11 to 16 in 085896a

	queue_.push_back({prec, work});
	}
	void
	WorkQueue::RunWorkUnits()
	{

!Line: 11 - error: use emplace_back instead of push_back [hicpp-use-emplace,modernize-use-emplace,-warnings-as-errors]

Looper/engine/game/animatable.cpp

Lines 90 to 95 in 085896a

	do
	{
	updateTime -= animationDurationMs;
	animationValue +=
	currentState_.m_currentAnimationEnd - currentState_.m_currentAnimationBegin;

!Line: 90 - error: avoid do-while loops [cppcoreguidelines-avoid-do-while,-warnings-as-errors]

Looper/engine/game/object.cpp

Lines 6 to 11 in 085896a

	TypeToString(ObjectType type)
	{
	std::string typeStr;
	switch (type)
	{

!Line: 6 - error: function 'TypeToString' declared 'static', move to anonymous namespace instead [misc-use-anonymous-namespace,-warnings-as-errors]